Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't have TerminalShellExecution#exitCode #208648

Closed
jrieken opened this issue Mar 25, 2024 · 0 comments · Fixed by #209041
Closed

Don't have TerminalShellExecution#exitCode #208648

jrieken opened this issue Mar 25, 2024 · 0 comments · Fixed by #209041
Assignees
@Tyriar
Labels
api bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
April 2024

Comments

@jrieken
Copy link
Member

jrieken commented Mar 25, 2024

Testing #208462

It's unexpected to have exitCode as a promise. It duplicates what onDidEndTerminalShellExecution is for. Instead, the onDidEndTerminalShellExecution-event could send an object with { execution, exitCode }.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug api terminal-shell-integration Shell integration, command decorations, etc. labels Mar 25, 2024
@Tyriar Tyriar added this to the April 2024 milestone Mar 25, 2024
Tyriar added a commit that referenced this issue Mar 28, 2024
@Tyriar
Move exitCode into TerminalShellExecutionEndEvent
a50a6bf 
Fixes #208648
@Tyriar Tyriar mentioned this issue Mar 28, 2024
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Mar 28, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 4, 2024
@andreamah andreamah added the verified Verification succeeded label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
api bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
April 2024
Development

Successfully merging a pull request may close this issue.

Move exitCode into TerminalShellExecutionEndEvent microsoft/vscode
4 participants
@jrieken @Tyriar @andreamah @VSCodeTriageBot