Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd+down quick tree shortcut doesn't always show the focused item #208696

Closed
roblourens opened this issue Mar 25, 2024 · 1 comment · Fixed by #208953
Closed

cmd+down quick tree shortcut doesn't always show the focused item #208696

roblourens opened this issue Mar 25, 2024 · 1 comment · Fixed by #208953
Assignees
@TylerLeonhardt
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
March 2024

Comments

@roblourens
Copy link
Member

Testing #208477

image

Here, I pressed cmd+down and it selected the first item under tsx.tx, but only reveled the title element before it. I think it should also show the item that is selected, it helps me keep my place.
TylerLeonhardt added a commit that referenced this issue Mar 27, 2024
@TylerLeonhardt
Reveal first child, not separator
74ab66d 
Fixes #208696
@TylerLeonhardt TylerLeonhardt mentioned this issue Mar 27, 2024
Merged
@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Mar 27, 2024
@TylerLeonhardt TylerLeonhardt added this to the March 2024 milestone Mar 27, 2024
@TylerLeonhardt
Copy link
Member

Verification:

  • Open Quick Search
  • type something like hi
  • scroll so that just the file name (separator) is the last visible item
  • hit cmd/alt+down until focus is given to the item right under that separator

Ensure it is revealed to you.

TylerLeonhardt added a commit that referenced this issue Mar 27, 2024
@TylerLeonhardt
Reveal first child, not separator (#208953)
b065dc2 
Fixes #208696
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 27, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 28, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TylerLeonhardt TylerLeonhardt

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
March 2024
Development

Successfully merging a pull request may close this issue.

Reveal first child, not separator microsoft/vscode
5 participants
@roblourens @TylerLeonhardt @rzhao271 @andreamah @VSCodeTriageBot