New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add accessibility help extension contributions pt #210116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! In addtion to my inline comments, why is the accessibilityHelpContent
contribution only a string and not also a markdown string?
src/vs/workbench/contrib/accessibility/browser/accessibleView.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/accessibility/browser/accessibleView.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/accessibility/browser/accessibleView.ts
Outdated
Show resolved
Hide resolved
done |
src/vs/workbench/contrib/accessibility/browser/accessibleViewContributions.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss how keybindings should be expressed at an API sync before merging this
To discuss in API sync:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have my approval, but I unchecked auto-merge since Matt wants to discuss at the API sync.
a7d3be8
to
6507804
Compare
@mjbvz discussed with Jo at the API sync and he has signed off on what I'm doing for keybindings. I will get feedback on and defer this part #210665:
|
This includes:
accessibleHelpContent
AcessibleViewInformationService
toworkbench/services
so the view service can understand if an accessible view has been shown already in that layer<keybinding:commandId>
to the keybinding, if any, or a message and linked command to configure the keybinding