Skip to content

add accessibility help dialog for issues/PR views#5934

Merged
meganrogge merged 7 commits intomainfrom
merogge/ghpr-accessible-view
Apr 18, 2024
Merged

add accessibility help dialog for issues/PR views#5934
meganrogge merged 7 commits intomainfrom
merogge/ghpr-accessible-view

Conversation

@meganrogge
Copy link
Copy Markdown
Contributor

@meganrogge meganrogge commented Apr 18, 2024 •
edited
Loading

fixes #5933

Once microsoft/vscode#210116 is merged shortly, we can adopt this here 😄 .

I am out tomorrow until Tuesday, so pls tweak and merge this.

I added most commands from the list JooYoung provided to the dialog. #5933 (comment)

@vscodenpa vscodenpa added this to the April 2024 milestone Apr 18, 2024
@meganrogge meganrogge enabled auto-merge (squash) April 18, 2024 15:46
@meganrogge meganrogge requested a review from alexr00 April 18, 2024 15:47
@meganrogge meganrogge merged commit d719f3e into main Apr 18, 2024
@meganrogge meganrogge deleted the merogge/ghpr-accessible-view branch April 18, 2024 15:50
meganrogge added a commit that referenced this pull request Apr 18, 2024
@meganrogge
Revert "add accessibility help dialog for issues/PR views (#5934)"
6acb96e 
This reverts commit d719f3e.
@meganrogge meganrogge mentioned this pull request Apr 18, 2024
Merged
@meganrogge meganrogge restored the merogge/ghpr-accessible-view branch April 18, 2024 15:53
@meganrogge
Copy link
Copy Markdown
Contributor Author

meganrogge commented Apr 18, 2024

this was approved and merged prematurely, reverting

meganrogge added a commit that referenced this pull request Apr 18, 2024
@meganrogge
add accessibility help dialog for issues/PR views (#5934)
3d55486
meganrogge added a commit that referenced this pull request Apr 18, 2024
@meganrogge
Revert "add accessibility help dialog for issues/PR views (#5934)" (#…
916697b 
…5935)

This reverts commit d719f3e.
meganrogge added a commit that referenced this pull request Apr 18, 2024
@meganrogge
add accessibility help dialog for issues/PR views (#5934)
c56eb16
alexr00 added a commit that referenced this pull request Apr 22, 2024
@meganrogge @alexr00
add GHPR accessibility help (#5936)
33751f1 
* add accessibility help dialog for issues/PR views (#5934)

* fix #5933

* Localize, fix errors, remove markdown syntax

---------

Co-authored-by: Alex Ross <alros@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benibenj benibenj benibenj approved these changes

@alexr00 alexr00 Awaiting requested review from alexr00

Assignees

@meganrogge meganrogge

Labels

None yet

Projects

None yet

Milestone

April 2024

Development

Successfully merging this pull request may close these issues.

Add GHPR accessibility help dialog

4 participants

@meganrogge @benibenj @vscodenpa @alexr00