Window activity API - window becomes inactive during long running git operation

[lszomoru]

Testing #210978

• Add a git pre-commit hook that sleeps for 120 seconds
• Make a change to a file, and commit the change
• Switch to another VS Code window

Expected behaviour:

• Window should be active while the source control operation running

Actual behaviour:

• Window becomes inactive even though the source control operation is still running

[connor4312]

Can this be adopted in SCM? Holding an activity lock is fairly easy, just call this method 🙂

vscode/src/vs/workbench/services/userActivity/common/userActivityService.ts

Lines 29 to 34 in 73a4cd4

	/**
	* Marks the user as being active until the Disposable is disposed of.
	* Multiple consumers call this method; the user will only be considered
	* inactive once all consumers have disposed of their Disposables.
	*/
	markActive(): IDisposable;

[lszomoru]

@connor4312, these commands are being contributed by the git extension. Should markActive() be wired into the IProgressService so that in case there is an on-going progress indicator the window is considered active?

[connor4312]

Yea, I think that's reasonable, thanks for the suggestion. Will take care of it 🙂