Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support full range of function breakpoint fields in plugin addBreakpoints #211894

Closed
OccasionalDebugger opened this issue May 3, 2024 · 3 comments · Fixed by #211895
Closed

Support full range of function breakpoint fields in plugin addBreakpoints #211894

OccasionalDebugger opened this issue May 3, 2024 · 3 comments · Fixed by #211895
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
May 2024

Comments

@OccasionalDebugger
Copy link
Contributor

At the moment, it is possible to pass a FunctionBreakpoint instance with the full range of fields configured, but when the breakpoint is eventually inserted, only the name and mode are included.

It would increase the power of the API to pass the full set of fields.
@OccasionalDebugger OccasionalDebugger mentioned this issue May 3, 2024
Merged
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels May 8, 2024
@roblourens roblourens added this to the May 2024 milestone May 8, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label May 8, 2024
roblourens added a commit that referenced this issue May 8, 2024
@roblourens
Add test for FunctionBreakpoint change
54e5ecb 
See #211894
@roblourens roblourens mentioned this issue May 8, 2024
Merged
roblourens added a commit that referenced this issue May 8, 2024
@roblourens
Add test for FunctionBreakpoint change (#212284)
9c336bf 
See #211894
SimonSiefke pushed a commit to SimonSiefke/vscode that referenced this issue May 8, 2024
@roblourens @SimonSiefke
Add test for FunctionBreakpoint change (microsoft#212284)
e8b00bc 
See microsoft#211894
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 9, 2024
@alexr00 alexr00 added the ~verification-steps-needed Steps to verify are needed (with bot comment) label May 29, 2024
@VSCodeTriageBot
Copy link
Collaborator

Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.

@VSCodeTriageBot VSCodeTriageBot added verification-steps-needed Steps to verify are needed for verification and removed ~verification-steps-needed Steps to verify are needed (with bot comment) labels May 29, 2024
@AP1400

This comment was marked as spam.

Sign in to view
@roblourens
Copy link
Member

Steps: from an extension, call debug.addBreakpoints(new FunctionBreakpoint(...)) and verify that the breakpoint shows up in the UI, and in the debug.breakpoints list, with all the correct fields that you passed in the FunctionBreakpoint constructor.

@lramos15 lramos15 removed the verification-steps-needed Steps to verify are needed for verification label May 29, 2024
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
May 2024
Development

Successfully merging a pull request may close this issue.

Pass full function breakpoint options from plugin OccasionalDebugger/vscode
7 participants
@roblourens @TylerLeonhardt @lramos15 @alexr00 @AP1400 @VSCodeTriageBot @OccasionalDebugger