Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disposing a tree view while it's visible causes it to stay empty #212078

Closed
alexr00 opened this issue May 6, 2024 · 1 comment
Closed

Disposing a tree view while it's visible causes it to stay empty #212078

alexr00 opened this issue May 6, 2024 · 1 comment
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release tree-views Extension tree view issues verified Verification succeeded
Milestone
April 2024 Recove...

Comments

@alexr00
Copy link
Member

alexr00 commented May 6, 2024 •
edited
Loading

  1. Extension creates a tree view
  2. User opens the tree view
  3. Extension disposes the tree view while it's still open
  4. Extension creates the tree view again
  5. 🐛 The tree view will stay empty until it's visibility is toggled

Real world repo (also works as steps to verify):

  1. Connect to a Codespace (to use a specific build of VS Code you can specify a commit in the URL with /?vscodeCommitId=<commit>, ex /?vscodeCommitId=d850cd0dffe788501c6719c298936d0d9128cb1f)
  2. Open the Remote Explorer
  3. Reload the page. This will cause the Codespace to load with the remote explorer visible
  4. You'll see that the Codespace view in the remote explorer is empty
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release tree-views Extension tree view issues labels May 6, 2024
@alexr00 alexr00 added this to the April 2024 Recovery 1 milestone May 6, 2024
@alexr00 alexr00 self-assigned this May 6, 2024
alexr00 added a commit that referenced this issue May 6, 2024
@alexr00
Disposing a tree view while it's visible causes it to stay empty
c819d18 
Part of #212078
@alexr00 alexr00 mentioned this issue May 6, 2024
Merged
alexr00 added a commit that referenced this issue May 6, 2024
@alexr00
Disposing a tree view while it's visible causes it to stay empty
77b0147 
Part of #212078
@alexr00 alexr00 mentioned this issue May 6, 2024
Merged
alexr00 added a commit that referenced this issue May 6, 2024
@alexr00
Disposing a tree view while it's visible causes it to stay empty (#21…
4cfcf34 
…2084)

Part of #212078
alexr00 added a commit that referenced this issue May 6, 2024
@alexr00
Disposing a tree view while it's visible causes it to stay empty (#21…
dc96b83 
…2085)

Part of #212078
@alexr00 alexr00 closed this as completed May 6, 2024
@aeschli aeschli added the verified Verification succeeded label May 7, 2024
@PA4WD PA4WD mentioned this issue May 15, 2024
Open
@MAHEENKANNOOZ

This comment was marked as spam.

Sign in to view
@microsoft microsoft locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
April 2024 Recovery 1
Development

No branches or pull requests
4 participants
@aeschli @alexr00 @MAHEENKANNOOZ and others