Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git bash slow since last update #214407

Closed
xGeekoo opened this issue Jun 6, 2024 · 30 comments
Closed

Git bash slow since last update #214407

xGeekoo opened this issue Jun 6, 2024 · 30 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@xGeekoo
Copy link

xGeekoo commented Jun 6, 2024

Type: Performance Issue

Since the last update, the integrated git bash terminal inside vscode have a high latency (around 5 seconds) after initialize it or running a command

Disabling all extension, removing settings and reinstalling git bash didn't fix the issue

VS Code version: Code 1.90.0 (89de5a8, 2024-06-04T19:33:54.889Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i7-11700K @ 3.60GHz (16 x 3600)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 31.88GB (23.92GB free)
Process Argv --crash-reporter-id 272e7d0b-09f8-4746-b771-4ed25fa88b99
Screen Reader no
VM 0%
Process Info
CPU %	Mem MB	   PID	Process
    0	   106	 16488	code main
    0	    81	  2656	fileWatcher [1]
    0	   105	  3024	   gpu-process
    0	    93	  7788	ptyHost
    0	     5	   360	     "C:\Program Files\Git\bin\bash.exe" --init-file "c:\Users\Geekoo\AppData\Local\Programs\Microsoft VS Code\resources\app/out/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh"
    0	    11	 18240	       "C:\Program Files\Git\bin\..\usr\bin\bash.exe" --init-file "c:\Users\Geekoo\AppData\Local\Programs\Microsoft VS Code\resources\app/out/vs/workbench/contrib/terminal/browser/media/shellIntegration-bash.sh"
    0	     6	  4092	     conpty-agent
    0	   101	 13804	shared-process
    0	    42	 13880	   utility-network-service
    0	   218	 16220	window [1] (settings.json - oauth2 - Visual Studio Code)
    0	   145	 16336	extensionHost [1]
    0	    96	 10356	     "C:\Users\Geekoo\AppData\Local\Programs\Microsoft VS Code\Code.exe" "c:\Users\Geekoo\AppData\Local\Programs\Microsoft VS Code\resources\app\extensions\json-language-features\server\dist\node\jsonServerMain" --node-ipc --clientProcessId=16336
    0	    89	 16060	     electron-nodejs (serverMain.js )
    0	   103	 16568	window [3] (Issue Reporter)
    0	    29	 18120	   crashpad-handler
Workspace Info
|  Window (settings.json - oauth2 - Visual Studio Code)
|    Folder (oauth2): 6 files
|      File types: json(2) env(1) gitignore(1) js(1)
|      Conf files: package.json(1);
Extensions (12)
Extension Author (truncated) Version
codesnap adp 1.3.4
vscode-tailwindcss bra 0.10.5
vscode-eslint dba 2.4.4
javascript-ejs-support Dig 1.3.3
prettier-vscode esb 10.4.0
auto-rename-tag for 0.1.10
dotenv mik 1.0.1
color-highlight nau 2.8.0
material-icon-theme PKi 5.3.0
LiveServer rit 5.7.9
svg-preview Sim 2.8.3
vscode-styled-components sty 1.7.8

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscorecescf:30445987
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
jchc7451:31067544
showvideoc:31016891
chatpanelt:31048053
dsvsc021:30996838
9c06g630:31013171
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
pythonprt:31056678
dwnewjupyter:31046869
fa862199:31048878

@shivapoudel
Copy link

It's so true that Git Bash is slow. I tried the external terminal, which is as expected but the integrated terminal is slow.

@xGeekoo
Copy link
Author

xGeekoo commented Jun 6, 2024

I just saw that settings "terminal.integrated.shellIntegration.enabled" to false fix the issue.
This settings seem to impact other issue related to other terminal too

#214386

@shivapoudel
Copy link

@xGeekoo For the current situation the setting as mentioned above works well. Thanks!

@hitrust
Copy link

hitrust commented Jun 6, 2024

Also, there is another issue, some characters have being attached to python venv's name, just like below.

x1b[36m\x1b[0m\x0d\x0a$ \x1b]633\x3bB\x07(prostarlette)

@hitrust
Copy link

hitrust commented Jun 6, 2024

It added some unnecessary features, it's just fine using version 1.88.1, and turn off the update.

@rud-holmgren
Copy link

I have the same issue - and "terminal.integrated.shellIntegration.enabled" seems to fix it.

Just wondering what other implications disabling that feature may have?

@JVJimenezC
Copy link

It added some unnecessary features, it's just fine using version 1.88.1, and turn off the update.

This fixed it for me.

My git bash was also displaying strange text and a line break before my "username@computer ~/folders/..." prompt

@meganrogge
Copy link
Contributor

/duplicate #212090

@VSCodeTriageBot VSCodeTriageBot added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 6, 2024
@meganrogge meganrogge removed *duplicate Issue identified as a duplicate of another issue(s) triage-needed labels Jun 6, 2024
@meganrogge meganrogge added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 6, 2024
@Lord-Fec
Copy link

Lord-Fec commented Jun 7, 2024

Thanks to @nbrinks, disable "shell integration" make git-bash faster!
image

@kira0x1
Copy link

kira0x1 commented Jun 7, 2024

god.. thank you this saved me.

I just saw that settings "terminal.integrated.shellIntegration.enabled" to false fix the issue. This settings seem to impact other issue related to other terminal too

#214386

@webgolub
Copy link

webgolub commented Jun 7, 2024

I just saw that settings "terminal.integrated.shellIntegration.enabled" to false fix the issue. This settings seem to impact other issue related to other terminal too

#214386

Unfortunately didn't work for me.
upd: everything worked, I just had to restart the terminal

@kira0x1
Copy link

kira0x1 commented Jun 7, 2024

I just saw that settings "terminal.integrated.shellIntegration.enabled" to false fix the issue. This settings seem to impact other issue related to other terminal too
#214386

Unfortunately didn't work for me.

make sure you click the delete / trash icon on the terminal and create a new one, hopefully that helps.

@James-Wilkinson-git
Copy link

Setting wouldnt save the first time had to do it a few times before it saved using the GUI, then restarted and it's back to normal.

@kira0x1
Copy link

kira0x1 commented Jun 7, 2024

Setting wouldnt save the first time had to do it a few times before it saved using the GUI, then restarted and it's back to normal.

wow

@DanielTheEntomologist
Copy link

DanielTheEntomologist commented Jun 8, 2024

It seems that whatever VCS is doing when wrapping Bash terminal is detected as suspicious activity by my antivirus.
Haven't tried disabling the antivirus to test if it would work as fix too.

@JP-Zeta
Copy link

JP-Zeta commented Jun 8, 2024

Thanks to @nbrinks, disable "shell integration" make git-bash faster! image

Thank you very much for the contribution, it worked for me, it was already giving me a headache because it took a long time to execute the code and print the message "b[0m\x0d\x0a$" at the end of it.

@ArkangelGab
Copy link

"terminal.integrated.shellIntegration.enabled"
The mentioned configuration does solve the problem. You must delete the terminal and reopen it for the changes to take effect.

@fpavlik
Copy link

fpavlik commented Jun 9, 2024

Oh lord, terminal.integrated.shellIntegration.enabled = false helped me too! Thank you!

@dhachcar
Copy link

terminal.integrated.shellIntegration.enabled = false fixed for me as well!

@jessicacastro
Copy link

@xGeekoo Thanks! The terminal.integrated.shellIntegration.enabled as false worked for mee. It was driving me crazy.

@LitoHDD
Copy link

LitoHDD commented Jun 10, 2024

Thanks to @nbrinks for the fix. Now Git Bash works as it should in your Windows version

maximool added a commit to maximool/config that referenced this issue Jun 10, 2024
@hugotannus
Copy link

hugotannus commented Jun 11, 2024

Also, there is another issue, some characters have being attached to python venv's name, just like below.

x1b[36m\x1b[0m\x0d\x0a$ \x1b]633\x3bB\x07(prostarlette)

@hitrust I was having the same issue, in node.js repository.

It seems to be kind of a "leak" of characters related to the coloration of the current branch name.

That was fixed just disabling the terminal.integrated.shellIntegration.enabled option as suggested above.

@djkepa
Copy link

djkepa commented Jun 12, 2024

well for me still the same 😢

@ivu-mawi
Copy link

I noticed that during these 5 second waits for the prompt, the Windows Defender CPU usage spikes. So, I wonder if Windows Defender exacerbates or causes the issue. I can't test that as I can't turn Defender off on my company laptop.

@abdul-florez
Copy link

Oh lord, terminal.integrated.shellIntegration.enabled =

Thank you!! it works for me!

@adan-garley
Copy link

thanks, it worked for me too.

@aidev13
Copy link

aidev13 commented Jun 12, 2024

terminal.integrated.shellIntegration.enabled helped me as well! Gosh, that was annoying...

@hitrust
Copy link

hitrust commented Jun 13, 2024

@hugotannus
Thanks.
Currently, I think it's enough using version 1.88.1, then no more uncertain annoying during working.

@bztoy
Copy link

bztoy commented Jun 13, 2024

Thanks everyone here, this issue was annoying me for 2 weeks time, the suggestion by @xGeekoo and everyone helped me as well.

@nyxisnyx
Copy link

Yep, i have the issue as well. The proposed fix solved some of it, but it's still about 50% as fast as it was before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests