The size of the vertical scroll bar in the integrated terminal does not match the size of the editor scroll bars

[uRohan]

Type: Bug

Steps to Reproduce:

1. Open Visual Studio Code.
2. Open the integrated terminal (usually accessible via View > Terminal).
3. Compare the vertical scroll bar size of the integrated terminal to the vertical scroll bar size of the editor.

Expected Behavior:

The size of the vertical scroll bar should be consistent. The vertical scroll bar in the integrated terminal should match the size of the vertical scroll bar in the editor.

Here's what it looks like:

Dark Modern	Light Modern

VS Code version: Code 1.90.1 (611f9bf, 2024-06-11T21:02:43.666Z), Code - Insiders 1.91.0-insider (b631c0a, 2024-06-18T08:27:24.007Z)
OS version: Linux x64 6.5.0-41-generic snap
Modes:

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-3610QM CPU @ 2.30GHz (8 x 3092)
GPU Status	2d_canvas: unavailable_software canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: disabled_software multiple_raster_threads: enabled_on opengl: disabled_off rasterization: disabled_software raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: disabled_software video_encode: disabled_software vulkan: disabled_off webgl: unavailable_software webgl2: unavailable_software webgpu: disabled_off
Load (avg)	2, 1, 1
Memory (System)	7.63GB (3.93GB free)
Process Argv	--force-user-env --no-sandbox --crash-reporter-id e8f86e41-3f8c-4aac-8c41-cb59fad957aa
Screen Reader	no
VM	0%
DESKTOP_SESSION	ubuntu
XDG_CURRENT_DESKTOP	Unity
XDG_SESSION_DESKTOP	ubuntu
XDG_SESSION_TYPE	wayland

Extensions: none

A/B Experiments

vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vscod805cf:30301675
vsaa593cf:30376535
py29gd2263:31024238
c4g48928:30535728
962ge761:30841072
pythongtdpath:30726887
welcomedialog:30812478
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30926734
pythonmypyd1:30859725
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
cppperfnew:30980852
pythonait:30973460
jchc7451:31067543
showvideot:31016890
chatpanelt:31014475
da93g388:31013173
a69g1124:31018687
dvdeprecation:31040973
pythonprt:31036556
dwnewjupyter:31046869
nb_pkg_only:31057982
nativerepl1:31071684
refactort:31073763

[meganrogge]

There's less space in the terminal, so a thinner scrollbar makes sense here IMO, @Tyriar reopen if you disagree

[Tyriar]

Something changed, it never used to be like this:

Maybe an Electron update changed what scroll bar styling is available?

[meganrogge]

May version is the same:

[Tyriar]

I think it's related to an Electron/Chrome update breaking how we styled scroll bars.

This doesn't seem easy to fix. The real fix here is to add API to xterm.js to allow the use of vscode's scrollable element.

[s-h-a-d-o-w]

There's less space in the terminal, so a thinner scrollbar makes sense here IMO

This is a significant accessibility problem. Not everybody can use a scroll wheel and grabbing a thin scroll bar can be difficult.
Thin scroll bars that can't be configured to be wider should not be acceptable for any project.

[Tyriar]

I disagree that it's significant, just wait until you try use one of our sashes to resize panes if you think this is hard to hit which I think has a 3px target:

Especially since there are alternate options (wheel, keybindings). Also the mouse target actually seems to be wider than the slider's size.

Regardless, here's scrollbar-width: thin with decorations:

And scrollbar-width: auto:

It's a shame this happened at all as the decorations were perfectly sized for the old scroll bar. auto does look better now and closer to the editor so we should go with that imo. Hopefully there aren't any side effects to making this change.

[s-h-a-d-o-w]

just wait until you try use one of our sashes to resize panes if you think this is hard to hit

Resizing panes is something that I do maybe once a month. But this is why I have a voice command for resizing windows to a specific size, since I can't avoid that as well.

It's understandable that not everything can be made accessible. But scrollbars are something where people have caused unnecessary frustration for many years now.

Hopefully there aren't any side effects to making this change.

Thanks, looking forward to this fix.