Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: New terminal scroll bar #223132

Closed
3 tasks done
Tyriar opened this issue Jul 22, 2024 · 0 comments
Closed
3 tasks done

Test: New terminal scroll bar #223132

Tyriar opened this issue Jul 22, 2024 · 0 comments

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 22, 2024

Refs: #216521

Complexity: 3

Create Issue


The terminal has a new scroll bar built on the one we use everywhere else! This took some pretty big changes behind the scenes in order to have xterm.js depend on part of VS Code's codebase. Please test the scroll bar, in particular check the following:

  • The editor and terminal scroll bars look and behave the same
  • Successful commands show up as blue in the left side of the overview ruler
  • Ctrl+c or empty commands show up as grey in the left side of the overview ruler
  • Failed commands show up as red in the right side of the overview ruler
  • Find results show up in the middle of the overview ruler
  • The overview ruler and scroll bar are pixel perfect positioned
  • Smooth scroll still works as expected ("terminal.integrated.smoothScrolling": true)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants