Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to add a disposable to a DisposableStore that has already been disposed of #218000

Closed
jrieken opened this issue Jun 25, 2024 · 0 comments · Fixed by #218235
Closed

Trying to add a disposable to a DisposableStore that has already been disposed of #218000

jrieken opened this issue Jun 25, 2024 · 0 comments · Fixed by #218235
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2024

Comments

@jrieken
Copy link
Member

jrieken commented Jun 25, 2024

This happens when reloading the window with a longish codeblock in the history

lifecycle.js:329 Error: Trying to add a disposable to a DisposableStore that has already been disposed of. The added object will be leaked!
    at DisposableStore.add (lifecycle.js:329:34)
    at ChatTextEditContentPart._register (lifecycle.js:393:32)
    at chatTextEditContentPart.js:104:30
    at async CodeCompareBlockPart.updateEditor (codeBlockPart.js:571:30)
    at async CodeCompareBlockPart.render (codeBlockPart.js:526:13)
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jun 25, 2024
@mjbvz mjbvz added this to the June 2024 milestone Jun 25, 2024
mjbvz added a commit to mjbvz/vscode that referenced this issue Jun 25, 2024
@mjbvz
Check disposal in async rendering
c1a610d 
Fixes microsoft#218000
@mjbvz mjbvz mentioned this issue Jun 25, 2024
Merged
@mjbvz mjbvz closed this as completed in 45db560 Jun 25, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 25, 2024
bricefriha pushed a commit to bricefriha/vscode that referenced this issue Jun 26, 2024
@mjbvz @bricefriha
Check disposal in async rendering (microsoft#218235)
d861d92 
Fixes microsoft#218000
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 26, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Jun 26, 2024
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this issue Jul 10, 2024
@mjbvz @aaronchucarroll
Check disposal in async rendering (microsoft#218235)
6b88440 
Fixes microsoft#218000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2024
Development

Successfully merging a pull request may close this issue.

Check disposal in async rendering mjbvz/vscode
4 participants
@jrieken @rzhao271 @mjbvz @VSCodeTriageBot