Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launching shared process is slow #22091

Closed
jrieken opened this issue Mar 6, 2017 · 5 comments
Closed

Launching shared process is slow #22091

jrieken opened this issue Mar 6, 2017 · 5 comments
Assignees
@joaomoreno
Labels
linux Issues with VS Code on Linux perf
Milestone
March 2017

Comments

@jrieken
Copy link
Member

jrieken commented Mar 6, 2017

We receive cpu profiles that show spawning the shared process being very slow in some cases.
screen shot 2017-03-06 at 18 18 16
@jrieken jrieken added the perf label Mar 6, 2017
@jrieken
Copy link
Member Author

jrieken commented Mar 6, 2017

I assume this resolves itself when we start to use a browser window, right?

@jrieken jrieken mentioned this issue Mar 6, 2017
Closed
@jrieken jrieken added the linux Issues with VS Code on Linux label Mar 6, 2017
@joaomoreno
Copy link
Member

joaomoreno commented Mar 7, 2017 •
edited
Loading

Hopefully so. Can I get your help on measuring perf after I merge #21879? This will happen today.

@joaomoreno joaomoreno added this to the March 2017 milestone Mar 7, 2017
@jrieken
Copy link
Member Author

jrieken commented Mar 7, 2017 •
edited
Loading

sure. easiest is to start with --prof-startup but we can then also profile the startup of the shared process

@jrieken jrieken mentioned this issue Mar 7, 2017
Closed
@FloMaetschke
Copy link

If you need someone to test, i am here! ;)

@joaomoreno
Copy link
Member

joaomoreno commented Mar 7, 2017 •
edited
Loading

@jrieken This is how it looks like now. Shared process is the last thing in there.

image

@cleidigh cleidigh mentioned this issue Mar 16, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
linux Issues with VS Code on Linux perf
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @FloMaetschke