Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal suggestions are highlighting for the completion text, not the label #221953

Closed
Tyriar opened this issue Jul 17, 2024 · 2 comments · Fixed by #221956
Closed

Terminal suggestions are highlighting for the completion text, not the label #221953

Tyriar opened this issue Jul 17, 2024 · 2 comments · Fixed by #221956
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-suggest verified Verification succeeded
Milestone
July 2024

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 17, 2024

Repro:

  1. Open pwsh
  2. Create a test folder
  3. Type yarn t

image

This is happening because the actual completion that will happen is .\test where the highlights would make more sense.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-suggest labels Jul 17, 2024
@Tyriar Tyriar added this to the July 2024 milestone Jul 17, 2024
@Tyriar Tyriar self-assigned this Jul 17, 2024
@Tyriar Tyriar mentioned this issue Jul 17, 2024
Merged
@Tyriar Tyriar closed this as completed in 47366d3 Jul 18, 2024
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 18, 2024
@Tyriar Tyriar mentioned this issue Jul 24, 2024
Closed
@alexr00
Copy link
Member

alexr00 commented Jul 25, 2024

Verified, but the font is strange:

Image

@alexr00 alexr00 added the verified Verification succeeded label Jul 25, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Jul 25, 2024

@alexr00 that's fixed but was only merged an hour ago #223507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-suggest verified Verification succeeded
Projects
None yet
Milestone
July 2024
Development

Successfully merging a pull request may close this issue.

Use completion text always instead of label microsoft/vscode
3 participants
@Tyriar @alexr00 @VSCodeTriageBot