Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme] allow to set editor gutter background #22410

Closed
gforcada opened this issue Mar 10, 2017 · 9 comments
Closed

[Theme] allow to set editor gutter background #22410

gforcada opened this issue Mar 10, 2017 · 9 comments
Assignees
Labels
editor-contrib Editor collection of extras feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@gforcada
Copy link

  • VSCode Version: 1.10.2
  • OS Version: Linux Fedora 25

When working with code that is all about nesting (i.e. SCSS) one really needs to see if the closing bracket 10 lines below the one you are in is at the very beginning or it has still some nesting. Usually editors help on that by having the line numbers background color be slightly different from the code background color.

So far I haven't seen any theme that makes this difference, is that because it is not possible? I would love to have that.

@ramya-rao-a ramya-rao-a added the themes Color theme issues label Mar 10, 2017
@ramya-rao-a
Copy link
Contributor

Can you share a screenshot of the expected behavior from any other editor that does this?

@gforcada
Copy link
Author

@ramya-rao-a yes of course, here it is
lines

You can clearly see where the lines and gutter ends and where the code starts.

@aeschli aeschli assigned alexdima and unassigned aeschli Mar 13, 2017
@aeschli aeschli added editor-contrib Editor collection of extras feature-request Request for new features or functionality and removed themes Color theme issues labels Mar 13, 2017
@alexdima
Copy link
Member

@gforcada Would any of the following work for you:

Option 1. indent guides "editor.renderIndentGuides": true

image

Option 2. render whitespace "editor.renderWhitespace": "boundary",

image

Option 3: "editor.renderLineHighlight": "gutter"

image

Option 4: "editor.rulers": [ 0 ]

image

@alexdima alexdima removed their assignment Mar 28, 2017
@alexdima alexdima added this to the Backlog milestone Mar 28, 2017
@alexdima alexdima added the themes Color theme issues label Mar 28, 2017
@gforcada
Copy link
Author

@alexandrudima thanks for all the tips, I only knew about the 2nd!

Indeed this alleviates a bit the need for a different color on the gutter, though personally, it still does not fulfill the same. But is low-priority now for me, so triage as you wish.

Thanks!

@alexdima
Copy link
Member

👍 I think the request is valid. We should offer themes the ability to customize the gutter background color

@albel727
Copy link

I was disappointed to find that this is not implemented in customizable theming still. I can't imagine what anyone making the gutter and the code be the same color could be thinking. But at least give us a way to save our eyes, please.

@aeschli aeschli self-assigned this May 12, 2017
@aeschli aeschli modified the milestones: May 2017, Backlog May 12, 2017
@gforcada
Copy link
Author

@albel727 I guess that you did not pay for this software, right? And I hope you are not forced to use it, right?

If that's the case and you want this feature, just like I do, at the very least not insulting the ones that are working on it will definitely help way more on raising awarness that this issue is important for us.

Keep it calm and educated please.

@albel727
Copy link

@gforcada I'm not sure what's the point of your guesses like "you didn't pay for a software that is free". It's free because Microsoft benefits from it indirectly. Therefore I can offer reasonable critique regardless of the amount of money paid, and it's in their own interest too. Zero insults were intended to be given, and even if they were, it isn't your duty or right to ask amends and reprimand me. Keep it calm and educated by not calling out people just because you feel like acting a social justice warrior on behalf of people who never asked you to do it.

@aeschli aeschli changed the title [Theme] Different color for line numbers background and code background [Theme] allow to set editor gutter background May 12, 2017
@aeschli
Copy link
Contributor

aeschli commented May 12, 2017

I added editorGutter.background' and 'peekViewEditorGutter.background

@aeschli aeschli closed this as completed May 12, 2017
@aeschli aeschli added the verification-needed Verification of issue is requested label May 30, 2017
@bpasero bpasero added the verified Verification succeeded label May 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-contrib Editor collection of extras feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants