Focus peek window on creation

[johnfn]

I love the peek window. It's pretty much the best thing ever.

I would love it ever so slightly more if VSCode would auto-focus it and insert the cursor where it belongs. e.g. if I clicked "peek definition", the cursor should be on the definition of what I peeked.

This idea seems so obvious I can't believe it's not part of the default implementation, but I know you guys have your reasons for doing things. 😄

If there is such a reason, could this at least be made a setting?

Thanks guys! ❤️

[jrieken]

Fiar request. The reasoning for focusing the tree of the left that you might wanna quickly skim through all references/definitions/etc to get fast overview. That's also the reason for changing the peek editor when the focus changes in the list.

We could add a command that allows to toggle between the selected reference/def and the peek view and then remember where you have been last

[johnfn]

Ah, I understand. Speaking to my own use case, I use peek definition at least 98% of the time that I use the peek window, so at least 98% of the time there's only one file in the tree, and highlighting the tree doesn't make much sense. (I think it's a bit of a UX problem with the "peek all references" - it feels a little too much information in too constrained a space, so I normally do a global search instead - but that's an alternate request.)

Your toggle command sounds great to me.

I would also love if there was a keyboard shortcut to focus back on the original text document.

[frabbit]

maybe the focus should be on the peek editor directly if there is only one entry in the list, that would be very helpful.

[idealatom]

Is there any progress being made on this?

[ognjenio]

Not entirely sure whether it's appropriate to add this here, but I'd also suggest two other things for the peek window that're in the same vein:

1. Splitting the "Keep peek editors open even when double clicking their content or when hitting escape" into two. The two aren't really equivalent, especially since double-clicking selects entire words and I'd for example like to be able to that, but still be able to close the window with Esc.

2. I'd suggest changing the tab order of the peek window for the editor to follow the list. That way, when the peek window is opened you can select the appropriate file and Tab into it instead of Shift+Tabbing.

[nicksettoon]

Any push on this? this is a must have. I seriously don't know how people have gone without this.

[jrieken]

@nicksettoon This is an open source project, this issue is marked as 'help wanted', so how about you?

[GustavoASC]

@jrieken I'll give it a try, looking for a way to automatically focus on peek window when there is only one entry in the list, according to @frabbit suggestion.

Do you guys think it's a good solution?

[jrieken]

I'd say a command to move focus between them and then a setting to define is focused by default is the better solution. That makes the behaviour predictable, e.g I often press Enter when having just one reference I wouldn't want a new line then

[jrieken]

fyi - this is the place (and sample) for adding commands that use the peek view widget:

vscode/src/vs/editor/contrib/gotoSymbol/peek/referencesController.ts

Line 333 in e74086a

KeybindingsRegistry.registerCommandAndKeybindingRule({

[GustavoASC]

Besides, we still need a setting to define which component will receive focus by default when Peek Window is shown.

[nicksettoon]

@nicksettoon This is an open source project, this issue is marked as 'help wanted', so how about you?

@jrieken Sorry. I'm so far away from having time to learn how to contribute. I'd like to, but I'm still in college working on several other things at the moment. Also, wouldn't even know where to start learning how to build vscode extensions and stuff.

[jrieken]

fyi - I have change the setting to: peekWidgetDefaultFocus?: 'tree' | 'editor';