Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate entries in default-keybindings #23393

Closed
jrieken opened this issue Mar 28, 2017 · 2 comments
Closed

duplicate entries in default-keybindings #23393

jrieken opened this issue Mar 28, 2017 · 2 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone
March 2017

Comments

@jrieken
Copy link
Member

jrieken commented Mar 28, 2017 •
edited

re #23315

  • open default keybindings
  • search for keepEditor
  • 馃悰 it's in there twice
{ "key": "cmd+k enter",           "command": "workbench.action.keepEditor" },
{ "key": "cmd+k enter",           "command": "workbench.action.keepEditor" },
@jrieken
Copy link
Member Author

jrieken commented Mar 28, 2017

related to enter

screen shot 2017-03-28 at 13 02 00

@alexdima alexdima added keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues labels Mar 28, 2017
@alexdima alexdima added this to the March 2017 milestone Mar 28, 2017
@alexdima
Copy link
Member

Looks like since both NumpadEnter and Enter map to VKEY_ENTER, we create two bindings...

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X linux Issues with VS Code on Linux labels Mar 28, 2017
@jrieken jrieken added the verified Verification succeeded label Mar 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
2 participants
@jrieken @alexdima