Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming for status bar icons and status bar extensions #23526

Closed
pahen opened this issue Mar 29, 2017 · 4 comments
Closed

Theming for status bar icons and status bar extensions #23526

pahen opened this issue Mar 29, 2017 · 4 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality themes Color theme issues verified Verification succeeded
Milestone
April 2017

Comments

@pahen
Copy link

pahen commented Mar 29, 2017

#23294

Tested in version 1.11.0-insider and statusBarForeground was changed to red here but it didn't apply to all text in the status bar.

screen shot 2017-03-29 at 09 30 01
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Mar 29, 2017
@bpasero bpasero added this to the March 2017 milestone Mar 29, 2017
@bpasero bpasero changed the title statusBarForeground doesn't apply to all text in status bar Theming for status bar icons and extensions Mar 29, 2017
@bpasero bpasero modified the milestones: April 2017, March 2017 Mar 29, 2017
@bpasero bpasero added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Mar 29, 2017
@bpasero bpasero changed the title Theming for status bar icons and extensions Theming for status bar icons and status bar extensions Mar 29, 2017
@bpasero bpasero added the themes Color theme issues label Mar 29, 2017
@bpasero
Copy link
Member

bpasero commented Mar 29, 2017 •
edited

Two issues:

  • extensions can decide on the foreground color of their status bar items, overriding whatever the theme does
  • the SVG icons used in the status bar do not inherit the foreground color

@bpasero bpasero mentioned this issue Mar 31, 2017
Closed
@kumarharsh
Copy link
Contributor

SVG icons can just use "currentColor" in their markup to inherit the FG color.

@bpasero
Copy link
Member

bpasero commented Apr 1, 2017

@kumarharsh not sure that would work for us, we use CSS background: url(path/to/svg) to show these SVG icons anywhere.

@bpasero bpasero mentioned this issue Apr 1, 2017
Closed
bpasero added a commit that referenced this issue Apr 19, 2017
@bpasero
webkit-mask for status bar icons (fixes #23526)
9a5a392
@bpasero
Copy link
Member

bpasero commented Apr 19, 2017

I went with the webkit-mask approach.

@mjbvz mjbvz added the verification-needed Verification of issue is requested label Apr 26, 2017
@aeschli aeschli added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Apr 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
5 participants
@pahen @kumarharsh @bpasero @aeschli @mjbvz