Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search tree: adopt templated rendering #23912

Closed
bpasero opened this issue Apr 5, 2017 · 2 comments
Closed

Search tree: adopt templated rendering #23912

bpasero opened this issue Apr 5, 2017 · 2 comments
Assignees
@sandy081
Labels
debt Code quality issues
Milestone
April 2017

Comments

@bpasero
Copy link
Member

bpasero commented Apr 5, 2017 •
edited

Today the search tree is using ActionsRenderer which is basically a LegacyRenderer that has to create all DOM elements for each item. Much better to directly extend IRenderer and adopt the templated approach to rendering (see CallStackRenderer for example).
@bpasero bpasero added the debt Code quality issues label Apr 5, 2017
@sandy081 sandy081 added this to the April 2017 milestone Apr 10, 2017
@bpasero
Copy link
Member Author

bpasero commented Apr 10, 2017

Awesome!

sandy081 added a commit that referenced this issue Apr 10, 2017
@sandy081
#23912 Adopt actions
ec89a59
@sandy081
Copy link
Member

@roblourens FYI, I changed the Search tree renderer to not to use the Legacy renderer, instead use the templated IRenderer. Heard that you wanted to do some changes in this area, hence mentioning you.

@roblourens roblourens mentioned this issue Apr 12, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
debt Code quality issues
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
2 participants
@bpasero @sandy081