Regression: dvorak-qwerty commands keyboard layout no longer works correctly

[darknoon]

• VSCode Version: Code 1.11.0 (9122ec4, 2017-04-05T20:52:01.201Z)
• OS Version: Darwin x64 16.5.0
• Extensions:

Extension	Author	Version
vscode-eslint	dbaeumer	1.2.8
flow-for-vscode	flowtype	0.5.0
JavaScriptSnippets	xabikos	1.4.0
ReactSnippets	xabikos	1.2.1

---

Steps to Reproduce:

1. Press command-s key on keyboard, should save
2. Action is Open not save :(

Started happening when I updated to the latest version

[darknoon]

Seems to dup #23964

[darknoon]

Appears related to work on #17521

[gyzerok]

Are there any way to workaround it or downgrade VSCode to the previous version meanwhile?

[alexdima]

Workaround: switch VS Code to dispatch based on key code again. Add the following setting:
"keyboard.dispatch": "keyCode" and restart VS Code

---

I would really like to understand your setup. I'm sorry for the breakage, I am really trying to get this right. Could you please explain like I'm five how to get into your setup (I thought the whole point of dvorak is that its not qwerty -- the name contradicts itself, r cannot be both between o and a and between e and t), and what key combination fails. It would also help to attach here what our C++ node module detects (open an editor, press F1 > Developer: Inspect Keyboard Mappings save the output to a file and attach here).

[alexdima]

Duplicate of #23964

[darknoon]

@alexandrudima thanks a lot for following up with the workaround! after I set that setting, my keybindings are working again!

[darknoon]

@alexandrudima I understand this is a little confusing. It's a keyboard layout that AFAIK doesn't exist on windows. Basically, it's Dvorak except when you're holding down the command (⌘) key, where it reverts back to qwerty. This is done because all of the key commands in macOS are designed ergonomically rather than by what the letter is.

So it would defeat the purpose of DVORAK if your commands had their ergonomics messed up by it, so I used this hybrid (which has been supported since ancient times on mac os classic etc).

[crwang]

I'm getting the same thing on my Mac.

When I used windows, I used to use this: https://github.com/bradfeehan/Dvorak-QWERTY-Ctrl to do the same thing that the Mac supports for their Dvorak-Qwerty keyboard setup.