Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debug] Option for 'evaluate' if it comes from watch or console #252

Closed
isidorn opened this issue Nov 19, 2015 · 4 comments
Closed

[debug] Option for 'evaluate' if it comes from watch or console #252

isidorn opened this issue Nov 19, 2015 · 4 comments
Assignees
@isidorn
Labels
feature-request Request for new features or functionality on-testplan verified Verification succeeded

Comments

@isidorn
Copy link
Contributor

isidorn commented Nov 19, 2015

Assigning this to you Andre so you add it to the protocal and then give it back to me to implement.

Requested by @daviwil
@daviwil
Copy link
Contributor

daviwil commented Nov 19, 2015

Yeah! This will be really useful.

@weinand weinand added the feature-request Request for new features or functionality label Nov 19, 2015
weinand added a commit that referenced this issue Nov 20, 2015
@weinand
add 'context' attribute to evaluate request. Partial fix for #252.
7831552
@weinand
Copy link
Contributor

weinand commented Nov 20, 2015

I've added an optional attribute 'context' to the Evaluate request. Isi, please add the appropriate context values ('watch', 'repl') to the evaluate calls.

@weinand weinand assigned isidorn and unassigned weinand Nov 20, 2015
weinand added a commit to microsoft/vscode-node-debug that referenced this issue Nov 20, 2015
@weinand
add 'context' attribute to evaluate request. Partial fix for microsof…
99bf42f 
…t/vscode#252.
weinand added a commit to microsoft/vscode-mono-debug that referenced this issue Nov 20, 2015
@weinand
add 'context' attribute to evaluate request. Partial fix for microsof…
cf37e96 
…t/vscode#252.
@daviwil
Copy link
Contributor

daviwil commented Nov 20, 2015

Attribute and values sound great to me.

@daviwil daviwil mentioned this issue Nov 20, 2015
Closed
@daviwil
Copy link
Contributor

daviwil commented Nov 20, 2015

👍

Looking forward to using this!

rudygt pushed a commit to rudygt/vscode-node-debug that referenced this issue Nov 24, 2015
@weinand
add 'context' attribute to evaluate request. Partial fix for microsof…
57fedeb 
…t/vscode#252.
@isidorn isidorn added the verified Verification succeeded label Feb 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
feature-request Request for new features or functionality on-testplan verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@daviwil @weinand @isidorn @VSCodeTriageBot