Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why does Code assume that *everything* i'm typing/about to expand is going to be PHP? #25218

Closed
iaremarkus opened this issue Apr 24, 2017 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) emmet Emmet related issues

Comments

@iaremarkus
Copy link

  • VSCode Version: Code 1.11.2 (6eaebe3, 2017-04-13T07:56:42.517Z)
  • OS Version: Darwin x64 16.5.0
  • Extensions:
Extension Author Version
Bookmarks alefragnani 0.14.1
color-info bierner 0.4.1
vscode-svgviewer cssho 1.4.0
divider dinhani 1.1.0
githistory donjayamanne 0.2.0
php-debug felixfbecker 1.10.0
php-intellisense felixfbecker 1.1.5
auto-close-tag formulahendry 0.3.11
prettify-json mohsen1 0.0.3
vscode-less mrmlnc 0.6.2
color-highlight naumovs 2.1.3
advanced-new-file patbenatar 0.4.3
slack sozercan 0.0.13
Align steve8708 0.2.0
theme-markcustom Mark 0.0.1
wordpress-snippet tungvn 1.1.2

Steps to Reproduce:

  1. When using Emmet-style HTML, anything I type is always assumed to be PHP which means when I hit 'tab' to complete/expand, it ignores my HTML and opens a PHP tag:

code

@ramya-rao-a
Copy link
Contributor

In your gif above, you do get the emmet expansion in the end.
How did you get that, if TAB adds php tag?

@iaremarkus
Copy link
Author

iaremarkus commented Apr 25, 2017 via email

@ramya-rao-a
Copy link
Contributor

Ah! got it

The item from the suggestion list gets expanded on TAB (which is not the right one in this case) and when you escape it and TAB again, emmet jumps in.

This is being tracked in #1952

You have a couple of options for working around this.
See #1952 (comment) and #1952 (comment)

We are also working on a way to get the emmet abbreviation expansion in the suggestion list itself.
That work is being tracked in #21943

@ramya-rao-a ramya-rao-a added emmet Emmet related issues *duplicate Issue identified as a duplicate of another issue(s) labels Apr 25, 2017
@ramya-rao-a
Copy link
Contributor

@wondergryphon

See #1952 (comment) for updates on this issue. You can now get emmet abbreviation expansion in the suggestion list. This way <?php will not be accidentally chosen

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) emmet Emmet related issues
Projects
None yet
Development

No branches or pull requests

2 participants