-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colorCustomizations: Do we need editorLinkForeground? #25474
Comments
It seems linkForeground got introduced when @sandy081 and @alexandrudima added support for more tmTheme global settings. But it seems to me 'linkForeground' got added by us as it is not used by tmTheme. I'm also in favour of removing is. editorActiveLinkForeground is good enough. |
I'm in favor of removing it too. We discussed this before in #18738 and why it feels weird. |
I don't have super strong feelings on it either, including it here means committing to it though and it does lead to slightly quirky behavior when used in themes imo. |
I agree the current behavior is odd. It used to not be needed when the |
No @joshpeng, my theme shows weird colors for link comments at the moment. |
#25328
editorLinkForeground
is similar toeditorActiveLinkForeground
but instead of needing ctrl/cmd held with mouse over it colors the link all the time. As far as I can tell we're not using this in any theme and it could only do harm imo. Coloring the text should be the role of the textmate scopes. We already underline them, why give users the option of overriding the links?For example, this is clearly invalid json due to the coloring:
It's not so clear with
"editorLinkForeground": "#FFFF00"
:Overrides coloring in comments/strings:
The text was updated successfully, but these errors were encountered: