colorCustomizations: Do we need editorLinkForeground?

[Tyriar]

#25328

• VSCode Version: Code - Insiders 1.12.0-insider (48ae6e3, 2017-04-26T06:32:53.505Z)
• OS Version: Linux x64 4.10.0-19-generic
• Extensions:

Extension	Author	Version
EditorConfig	EditorConfig	0.9.3
lorem-ipsum	Tyriar	1.0.0
sort-lines	Tyriar	1.2.0
theme-sapphire	Tyriar	0.1.0
vscode-svgviewer	cssho	1.4.0
tslint	eg2	0.12.0
git-project-manager	felipecaputo	1.3.2
md-navigate	jrieken	0.0.1
vscode-scss	mrmlnc	0.6.2
vetur	octref	0.6.3
seti-icons	qinjia	0.1.3

---

editorLinkForeground is similar to editorActiveLinkForeground but instead of needing ctrl/cmd held with mouse over it colors the link all the time. As far as I can tell we're not using this in any theme and it could only do harm imo. Coloring the text should be the role of the textmate scopes. We already underline them, why give users the option of overriding the links?

For example, this is clearly invalid json due to the coloring:

It's not so clear with "editorLinkForeground": "#FFFF00":

Overrides coloring in comments/strings:

[aeschli]

It seems linkForeground got introduced when @sandy081 and @alexandrudima added support for more tmTheme global settings. But it seems to me 'linkForeground' got added by us as it is not used by tmTheme.

I'm also in favour of removing is. editorActiveLinkForeground is good enough.

[alexdima]

@joshpeng asked for it to be able to control it from his theme. @Tyriar please feel free to negotiate with @joshpeng the removal of the color. I have no strong feelings either way.

#18357 (comment)

Related discussion - #18378 i.e. @akamud might also be exercising the color in his theme.

[akamud]

I'm in favor of removing it too. We discussed this before in #18738 and why it feels weird.

[Tyriar]

I don't have super strong feelings on it either, including it here means committing to it though and it does lead to slightly quirky behavior when used in themes imo.

[joshpeng]

I agree the current behavior is odd. It used to not be needed when the detected-link scope worked, but with link styling coming in on top of TM scopes how would we color them otherwise? @akamud did you find another solution to this?

[akamud]

No @joshpeng, my theme shows weird colors for link comments at the moment.