Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming: Revisit Unsaved File Count Indicator #25493

Closed
mjbvz opened this issue Apr 26, 2017 · 1 comment
Closed

Theming: Revisit Unsaved File Count Indicator #25493

mjbvz opened this issue Apr 26, 2017 · 1 comment
Assignees
@bpasero
Labels
themes Color theme issues
Milestone
May 2017

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Apr 26, 2017

I was unable to find a way to theme the unsaved file indicator in the explorer:

screen shot 2017-04-26 at 4 36 32 pm
@mjbvz mjbvz added the themes Color theme issues label Apr 26, 2017
@bpasero bpasero added this to the April 2017 milestone Apr 27, 2017
@bpasero bpasero changed the title Cannot Theme Unsaved File Count Indicator Theming: Revisit Unsaved File Count Indicator Apr 27, 2017
@bpasero bpasero modified the milestones: May 2017, April 2017 Apr 27, 2017
bpasero added a commit that referenced this issue Apr 27, 2017
@bpasero
workaround #25493
bcf5eb2
@bpasero
Copy link
Member

bpasero commented Apr 27, 2017

Issues:

  • uses monaco-count-badge CSS class even though that is not the widget
  • uses a white foreground color which looks weird in other themes
  • now has a workaround to define colors via opacity (see here)

@bpasero bpasero closed this as completed in c615b43 May 9, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
themes Color theme issues
Projects
None yet
Milestone
May 2017
Development

No branches or pull requests
3 participants
@bpasero @aeschli @mjbvz