Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar is not clickable after changing Date & Time #25830

Closed
caixw opened this issue May 3, 2017 · 6 comments
Closed

Sidebar is not clickable after changing Date & Time #25830

caixw opened this issue May 3, 2017 · 6 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
May 2017

Comments

@caixw
Copy link

caixw commented May 3, 2017 •
edited

  • VSCode Version:
    1.11.2
  • OS Version:
    macOS 10.12.4
    Steps to Reproduce:
  1. 将系统时间往前调
  2. 侧边栏部分选项卡用鼠标点击没反应，但可以用快捷键进行切换。

@rebornix
@caixw
Copy link
Author

caixw commented May 3, 2017

刚把时间往后调了，然后回到正常时间，也出此问题。

@rebornix
Copy link
Member

rebornix commented May 6, 2017

@caixw 请问可以提供 gif 帮助 troubleshoot 吗？

@rebornix rebornix added the info-needed Issue requires more information from poster label May 6, 2017
@caixw
Copy link
Author

caixw commented May 7, 2017

vsc

@rebornix rebornix changed the title 点击侧边栏没反映 Sidebar is not clickable after changing Date & Time May 7, 2017
@rebornix
Copy link
Member

rebornix commented May 7, 2017 •
edited

@caixw thanks for the gif, it helps a lot. I can reproduce this with latest Insider on macOS.

cc @bpasero

@rebornix rebornix assigned bpasero and unassigned rebornix May 7, 2017
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels May 7, 2017
@rebornix
Copy link
Member

rebornix commented May 7, 2017

The triggering code is https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/activitybar/activitybarActions.ts#L86 . We check current time (which is already modified) against cached last-click-time, but due to the current time is not real current, the validation is not as expected.

It's a good catch and really interesting. But it's pretty rare and once you reload the window, the issue is gone.

@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label May 8, 2017
@bpasero bpasero added this to the Backlog milestone May 8, 2017
@bpasero
Copy link
Member

bpasero commented May 8, 2017

PR welcome.

@bpasero bpasero modified the milestones: May 2017, Backlog May 15, 2017
@bpasero bpasero removed the help wanted Issues identified as good community contribution opportunities label May 15, 2017
bpasero added a commit that referenced this issue May 15, 2017
@bpasero
Sidebar is not clickable after changing Date & Time (fixes #25830)
dc897c5
marckassay pushed a commit to marckassay/vscode that referenced this issue May 15, 2017
@bpasero @marckassay
Sidebar is not clickable after changing Date & Time (fixes microsoft#…
56d0f3b 
…25830)
@roblourens roblourens added the verified Verification succeeded label Jun 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
May 2017
Development

No branches or pull requests
4 participants
@roblourens @rebornix @bpasero @caixw