Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[json] Built-in JSON schemas should allow to be modified at runtime #27816

Closed
dbaeumer opened this issue Jun 1, 2017 · 2 comments
Closed

[json] Built-in JSON schemas should allow to be modified at runtime #27816

dbaeumer opened this issue Jun 1, 2017 · 2 comments
Assignees
@aeschli
Labels
feature-request Request for new features or functionality json JSON support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2017

Comments

@dbaeumer
Copy link
Member

dbaeumer commented Jun 1, 2017

  • VSCode Version: 1.13

See #27726 for the details.
@dbaeumer dbaeumer mentioned this issue Jun 1, 2017
Closed
@aeschli aeschli changed the title JSON schema should allow to be modified at runtime [json] Built-in JSON schemas should allow to be modified at runtime Jun 7, 2017
@aeschli aeschli added json JSON support issues feature-request Request for new features or functionality labels Jun 7, 2017
@aeschli aeschli added this to the Backlog milestone Jun 7, 2017
@aeschli aeschli modified the milestones: Backlog, September 2017 Sep 25, 2017
aeschli added a commit that referenced this issue Sep 25, 2017
@aeschli
Listen to schema change events (for #27816)
8b350a1
@aeschli
Copy link
Contributor

aeschli commented Sep 25, 2017 •
edited

Fixed by be3e1c3

You can now trigger a schema update by reregistering your schema with

Registry.as<JSONContributionRegistry.IJSONContributionRegistry>(JSONContributionRegistry.Extensions.JSONContribution).registerSchema(...)

Thanks @sandy081 !

@aeschli aeschli closed this as completed Sep 25, 2017
@dbaeumer
Copy link
Member Author

Thanks @aeschli

@aeschli aeschli added verification-needed Verification of issue is requested verified Verification succeeded labels Sep 26, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
feature-request Request for new features or functionality json JSON support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
2 participants
@dbaeumer @aeschli