Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"emmet.extensionsPath" incompatible with "emmet.useNewEmmet": true #28465

Closed
Fred-Vatin opened this issue Jun 11, 2017 · 3 comments
Closed

"emmet.extensionsPath" incompatible with "emmet.useNewEmmet": true #28465

Fred-Vatin opened this issue Jun 11, 2017 · 3 comments
Assignees
@ramya-rao-a
Labels
emmet Emmet related issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2017

Comments

@Fred-Vatin
Copy link

Fred-Vatin commented Jun 11, 2017 •
edited

VS Code version OS
1.13.0 Win x64 pro (french)

The new Emmet feature is awesome. Unfortunately, it will ignore the user setting "emmet.extensionsPath".

Steps to reproduce

  1. in settings.json:
    "emmet.extensionsPath": "path to\\Emmet Settings",
    "emmet.useNewEmmet": true,
  1. In Emmet Settings directory set above there is a custom snippets.json file containing for instance:
{
	"variables": {
		"charset": "UTF-8",
		"indentation": "\t",
		"lang": "fr",
		"locale": "fr-FR",
		"newline": "\n"
	},
	"html": {
		"abbreviations": {
			"doc": "html>(head>meta[charset=${charset}]+meta:vp+meta:edge+title{${1:Document}})+body",
			"html:5": "!!!+doc[lang=${lang}]"
		},
		"filters": "html",
		"profile": "html",
		"snippets": {
			"!!!": "<!DOCTYPE html>"
		}
	}
}
  1. In a HTML file use the emmet html:5 snippet

Result

Custom emmet snippets are ignored. Lang applied is "en". Same goes for any emmet custom snippets in "emmet.extensionsPath": "path to\\Emmet Settings": html, css, etc.

It will work as intended if "emmet.useNewEmmet": false

I hope this incompatibility issue with custom emmet settings will be solve.
@Fred-Vatin Fred-Vatin changed the title Emmet: "emmet.extensionsPath" incompatible with "emmet.useNewEmmet": true "emmet.extensionsPath" incompatible with "emmet.useNewEmmet": true Jun 11, 2017
@ramya-rao-a
Copy link
Contributor

Yes, in the new emmet model, its not very straight forward to re-use the previous custom snippets

I have included the investigation for this in #27697

Thanks for reporting!

@ramya-rao-a ramya-rao-a added the emmet Emmet related issues label Jun 12, 2017
@ramya-rao-a ramya-rao-a self-assigned this Jun 12, 2017
@ramya-rao-a ramya-rao-a mentioned this issue Jun 12, 2017
Closed
15 tasks
@ramya-rao-a
Copy link
Contributor

With ac60143 the syntaxProfiles.json and snippets.json from emmet.extensionsPath will be used.

The new emmet modules do not use the old style snippets. So only the variables section of the snippets.json will be honored.

Logged #29146 to track the inclusion of custom snippets

@ramya-rao-a ramya-rao-a added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Jun 26, 2017
@ramya-rao-a
Copy link
Contributor

Note to verifier:

@ramya-rao-a ramya-rao-a added this to the June 2017 milestone Jun 26, 2017
@roblourens roblourens added the verified Verification succeeded label Jun 28, 2017
@roblourens roblourens mentioned this issue Jun 28, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
emmet Emmet related issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
3 participants
@roblourens @ramya-rao-a @Fred-Vatin