[python] Integrate MagicPython into VS Code

[MadSpindel]

MagicPython is so much better than the default Python syntax highlighter in VS Code. In my opinion, MagicPython should be the default Python syntax highlighter.

[alexdima]

fyi @aeschli

[nchammas]

+1

Apparently, GitHub uses MagicPython as part of Linguist.

[1st1]

@aeschli Hi Martin,

I'm looking at f496772 -- I think we should give the schemas (tmLanguage) different names, i.e.:

"name": "MagicPython",

should really be

"name": "Python",

(same for regexp syntax).

Otherwise I'm afraid of potential compatibility issues with using MagicPython extension.

[DonJayamanne]

@1st1 , thanks for identifying that issue. Hopefully the new PR fixes that.

[aeschli]

@1st1 VSCode doesn't use the name in the tmLanguageFile. We instead use the first 'alias' in the language contribution: https://github.com/Microsoft/vscode/blob/master/extensions/python/package.json#L9.
Replacing a grammar is independent of its name. Any extension can replace the built-in grammar by making a grammar definition for the same language id, and by adding a extension dependency to the built-in grammar:

"contributes": {
    "grammars": [{
        "language": "python",
        "scopeName": "source.python",
        "path": "./syntaxes/MyNewPython.tmLanguage.json"
    }],
},
"extensionDependencies": [ "vscode.python" ]

[aeschli]

As the name is not used, we can of course still change it, but I recommend to keep it as is so that people can see where the grammar comes from.

[DonJayamanne]

Closing, as nothing further to be done anymore.