Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile syntax highlight bug, caused by comments #29048

Closed
Leedehai opened this issue Jun 19, 2017 · 3 comments
Closed

Makefile syntax highlight bug, caused by comments #29048

Leedehai opened this issue Jun 19, 2017 · 3 comments
Assignees
@aeschli

Comments

@Leedehai
Copy link

  • VSCode Version: 1.13.1
  • OS Version: macOS 10.12.5

Steps to Reproduce:
In this Makefile snippet, the variable "HCC_LIB_OBJ" in the second line is not properly colored, due to comment at the end of the first line. If the comment is removed, "HCC_LIB_OBJ" is colored correctly. But "HCC_LIB_OBJ"'s colorization should not be affected by whether there is a comment in the preceding line.
image
image
@aeschli
Copy link
Contributor

aeschli commented Aug 11, 2017

Reproduced with

s = b b #eeee
c = d d d

@aeschli aeschli mentioned this issue Aug 11, 2017
Open
@aeschli
Copy link
Contributor

aeschli commented Aug 11, 2017

This issue was moved to textmate/make.tmbundle#17

@aeschli aeschli closed this as completed Aug 11, 2017
@fadeevab
Copy link
Contributor

Fixed here: #27293

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fadeevab @aeschli @chrmarti @Leedehai