Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php] Provide HTML tag matching/language service support #2915

Closed
adred opened this issue Feb 11, 2016 · 151 comments
Closed

[php] Provide HTML tag matching/language service support #2915

adred opened this issue Feb 11, 2016 · 151 comments
Assignees
Labels
*extension-candidate Issue identified as good extension implementation html HTML support issues php PHP support issues

Comments

@adred
Copy link

adred commented Feb 11, 2016

I don't know if it's just me but there's no support for HTML tag matching. If I click on div, every instance of div are highlighted instead of the closing </div>, which is a PITA.

@alexdima
Copy link
Member

@adred Maybe you are on an old version?

image

@aeschli aeschli added html HTML support issues info-needed Issue requires more information from poster labels Feb 11, 2016
@adred
Copy link
Author

adred commented Feb 12, 2016

screen shot 2016-02-12 at 11 15 17 am

OS X Yosemite. The same behaviour in Ubuntu 14.04.
VS Code version is 0.10.8

@aeschli aeschli added php PHP support issues and removed info-needed Issue requires more information from poster labels Feb 12, 2016
@aeschli aeschli added this to the Backlog milestone Feb 12, 2016
@aeschli aeschli changed the title HTML tag matching [php] Provide HTML tag matching Feb 12, 2016
@aeschli aeschli added the feature-request Request for new features or functionality label Mar 8, 2016
@sorinpopescu
Copy link

I have the same issue - http://prntscr.com/bnfaym

@LouWii
Copy link

LouWii commented Aug 8, 2016

👍

@nunosousa-dev
Copy link

Any update on this?
I have the same issue.

@giancarlo88
Copy link

I'm also having the same issue.

@Lazerproof
Copy link

Same here

@naumanahmed19
Copy link

naumanahmed19 commented Oct 15, 2016

same here for .blade.php

@aga5tya
Copy link

aga5tya commented Oct 18, 2016

Issue still persists on latest update, on twig and php files atleast, would love to hear if there is any progress? @alexandrudima

@alexjose
Copy link

+1

5 similar comments
@vasanth833
Copy link

+1

@rgfx
Copy link

rgfx commented Nov 19, 2016

+1

@robcaa
Copy link

robcaa commented Nov 20, 2016

+1

@moufeed
Copy link

moufeed commented Nov 22, 2016

+1

@cbrostrom
Copy link

+1

@aeschli
Copy link
Contributor

aeschli commented Feb 28, 2018

https://marketplace.visualstudio.com/items?itemName=bmewburn.vscode-intelephense-client implements tag matching for the HTML code in .php files.
image

Please give it a try and if it doesn't work for your use case, help to improve the extension and file an issue there.

@dpetratsch
Copy link

@aeschli Thanks for help, but intelephense isn't working for tag completion.

I installed vincaslt.highlight-matching-tag instead, which seems to do the job.

But nevertheless, this should be a core feature out of the box.

@aeschli
Copy link
Contributor

aeschli commented Mar 2, 2018

@petewulf intelliphense also has code completion in html-tags in PHP:
image

But this issue is about tag highlighting, not completion, so lets not continue the discussion here. If intelephense's code completion doesn't work in your scenario, file improvement requests directly against https://github.com/bmewburn/vscode-intelephense

@sshreya0808
Copy link

I am facing the same issue. Not sure how to handle this. This is for react js app in visual studio code.

@aeschli
Copy link
Contributor

aeschli commented Mar 9, 2018

@sshreya0808 This issue is about PHP. For React, please file a new issue with your code sample.

@sshreya0808
Copy link

@aeschli... Thanks

@ivanrojasdev
Copy link

you know if there is a plugin for Visual Studio Code, which allows me to highlight opening and closing tags as well as the sublime text BracketHighlighter

@adalgdev
Copy link

All of the suggestions are not working. 2yrs... Please fix this

@aeschli
Copy link
Contributor

aeschli commented Mar 12, 2018

@adal6a Please try the Intelliphense extension and please file issues against the extension with a code sample that shows what's not working for you.

@aditya43
Copy link

Open User Settings, and make sure you have following set to true:

"editor.occurrencesHighlight": true,

screenshot from 2018-03-13 12-34-11

@toddicus13
Copy link

toddicus13 commented Apr 9, 2018

"editor.matchBrackets": true,
"editor.occurrencesHighlight": true

@Ashu131
Copy link

Ashu131 commented Apr 17, 2018

Checked that settings

"editor.matchBrackets": true,
"editor.occurrencesHighlight": true

But Problem still the same @toddicus13 @aeschli @aditya43
vscodeerror

@toddicus13
Copy link

Ya @Ashu131 ...seems to only work in html files not php.

@Ashu131
Copy link

Ashu131 commented Apr 19, 2018

Okay. It worked for me @ramya-rao-a

@LucaChiappino
Copy link

LucaChiappino commented Jul 2, 2018

I don't know if there is some relation with this discussion but when the cursor is on a div, the vertical red line (on the left in the image) that supposed to indicate the closing tag is not following the correct div but his parent

image

I tried with php, html and Javascript and same error.

@KamasamaK
Copy link

KamasamaK commented Jul 2, 2018

@LucaChiappino That is the highlighted indent guide and is unrelated to tag matching. The placement is intentional.

@roblourens
Copy link
Member

As @aeschli says,

marketplace.visualstudio.com/items?itemName=bmewburn.vscode-intelephense-client implements tag matching for the HTML code in .php files.

And it's not likely we will try to support this out of the box so I will close this.

@roblourens roblourens removed this from the Backlog milestone Jul 9, 2018
@roblourens roblourens added *extension-candidate Issue identified as good extension implementation and removed feature-request Request for new features or functionality labels Jul 9, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*extension-candidate Issue identified as good extension implementation html HTML support issues php PHP support issues
Projects
None yet
Development

No branches or pull requests