Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong docs for snippets in suggestion list #29468

Closed
ramya-rao-a opened this issue Jun 26, 2017 · 2 comments
Closed

Wrong docs for snippets in suggestion list #29468

ramya-rao-a opened this issue Jun 26, 2017 · 2 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone
June 2017

Comments

@ramya-rao-a
Copy link
Contributor

From @vvs in #28933 (comment)

There is one issue though (actually two), regarding snippets.
Say, I have a snippet called bidi (for bi-directional SCSS mix-ins).

== Issue 1 ==

I type 'b' and see the following:

vc-emmet-1

The help for my snippet bidi is wrong.

== Issue 2 ==

When I type the full name of the snippet, bidi in this case, it is still listed below the Emmet suggestion (which seems completely unrelated to the name of my snippet):

vc-emmet-2
@vscodebot vscodebot bot added bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues labels Jun 26, 2017
@ramya-rao-a ramya-rao-a removed the bug Issue identified by VS Code Team member as probable bug label Jun 26, 2017
@ramya-rao-a ramya-rao-a added this to the June 2017 milestone Jun 26, 2017
@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Jun 26, 2017
@ramya-rao-a ramya-rao-a mentioned this issue Jun 26, 2017
Closed
@ramya-rao-a
Copy link
Contributor Author

The first issue will be fixed with 99ffa6a

Stale docs were showing up for snippet suggestions when suggestion list was initially triggered.

Logged #29473 as it is a different issue altogether

@ramya-rao-a
Copy link
Contributor Author

Note to verifier:

  • Set emmet.useNewEmmet to true
  • Have the snippet bidi with some description
  • Type bidi , expand docs to see the emmet related docs
  • Esc , backspace until you just have b, trigger suggestions again
  • You should see bidi with the right description

ramya-rao-a added a commit that referenced this issue Jun 26, 2017
@ramya-rao-a
Move state check ahead to ensure stale docs are not made visible #29468
99ffa6a
@roblourens roblourens added the verified Verification succeeded label Jun 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
2 participants
@roblourens @ramya-rao-a