Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve quick open input on Escape #29553

Closed
joaomoreno opened this issue Jun 27, 2017 · 2 comments
Closed

Preserve quick open input on Escape #29553

joaomoreno opened this issue Jun 27, 2017 · 2 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2018

Comments

@joaomoreno
Copy link
Member

Related to #29247

I expected my input would be preserved even if I pressed Escape in quick open, when using workbench.commandPalette.preserveInput.
@bpasero bpasero added feature-request Request for new features or functionality quick-pick Quick-pick widget issues workbench labels Jun 27, 2017
@bpasero bpasero removed their assignment Jun 27, 2017
@bpasero bpasero removed the workbench label Nov 16, 2017
@bpasero bpasero mentioned this issue Nov 17, 2017
Closed
@evandrocoan evandrocoan mentioned this issue Feb 20, 2018
Open
raynicho pushed a commit to raynicho/vscode that referenced this issue Apr 8, 2018
fixes microsoft#29553 preserve quick open input on escape
194af68
@raynicho raynicho mentioned this issue Apr 8, 2018
Closed
@bpasero bpasero self-assigned this Sep 12, 2018
@bpasero bpasero added this to the September 2018 milestone Sep 12, 2018
@bpasero bpasero added the verification-needed Verification of issue is requested label Sep 12, 2018
@isidorn
Copy link
Contributor

isidorn commented Sep 25, 2018

This does not work as I would expect it to -> reopening

"workbench.commandPalette.preserveInput": true,
I open quick open and type "debug"
Next time I open quick open "debug" is not typed

@isidorn isidorn reopened this Sep 25, 2018
@isidorn isidorn added the verified Verification succeeded label Sep 25, 2018
@isidorn isidorn closed this as completed Sep 25, 2018
@isidorn
Copy link
Contributor

isidorn commented Sep 25, 2018

This is only for the command pallete, thus verifiying

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

Successfully merging a pull request may close this issue.

fixes #29553 preserve quick open input on escape raynicho/vscode
3 participants
@joaomoreno @bpasero @isidorn