Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: History navigator does not re-order items when adding existing elements #29762

Closed
stringham opened this issue Jun 28, 2017 · 1 comment · Fixed by #29763
Closed
Assignees
Labels
debt Code quality issues
Milestone

Comments

@stringham
Copy link
Contributor

When #25780 was closed, the history navigator stopped re-ordering when adding an existing element.

Previously with ArraySet, the set method had:

set(element T): void {
    this.unset(element);
    this._elements.push(element);
}

since native Sets don't have this property, this needs to happen manually in the cases where we expect adding an item to the set to affect its order, like in history.ts.

@stringham
Copy link
Contributor Author

This was duplicated by #31953 and fixed with 3a69df3

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants