Fix history navigator to change the position when adding an existing element. #29763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringham
force-pushed
the
fix-search-history
branch
from
588244c
to
364760d
Compare
|
@sandy081 I think this is a pretty straightforward fix. Is there anything holding it up? |
|
This was independently fixed by 3a69df3 two months after I submitted this patch. It is difficult to contribute when pull requests are ignored. Especially very simple ones like this. |
|
@stringham Apologies for not getting this in. Missed my radar. I acknowledge your contribution. Thank you very much. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29762