Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet 2.0 "wrap with abbreviation" bug when partial line is selected #29857

Closed
smlombardi opened this issue Jun 29, 2017 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone

Comments

@smlombardi
Copy link

  • VSCode Version: Code - Insiders 1.14.0-insider (9541932, 2017-06-29T05:07:31.424Z)
  • OS Version: Darwin x64 16.6.0
  • Extensions:
Extension Author (truncated) Version
ng-template Ang 0.1.4
vscode-markdownlint Dav 0.9.1
code-settings-sync Sha 2.8.1
sort-lines Tyr 1.3.0
Bookmarks ale 0.15.2
project-manager ale 0.18.1
path-intellisense chr 1.4.2
vscode-eslint dba 1.2.11
vscode-html-css ecm 0.1.7
tslint eg2 0.16.0
auto-rename-tag for 0.0.14
Angular2 joh 2.3.3
ecdc mit 0.10.3
HTMLHint mka 0.3.3
vscode-stylefmt mrm 2.4.1
angular2-inline nat 0.0.17
stylelint shi 0.26.0
ayu tea 0.4.0
change-case wma 1.0.0

(4 theme extensions excluded)


Steps to Reproduce:

  1. Take this fragment of html: <h2>NG-Bootstrap Popovers</h2>
  2. Select the word "Popovers"
  3. Invoke "Emmet > Wrap with Abbreviation"
  4. type "code" to wrap word with the <code> tag
  5. Result is <h2>NG-Bootstrap <code> <h2>NG-Bootstrap Popovers</h2> </code></h2>

jun-29-2017 09-25-43

Reproduces without extensions: Yes/No

@ramya-rao-a ramya-rao-a changed the title Emmet 2.0 "wrap with abbreviation" confused Emmet 2.0 "wrap with abbreviation" bug when partial line is selected Jun 29, 2017
@ramya-rao-a ramya-rao-a added bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues and removed editor labels Jun 29, 2017
@ramya-rao-a ramya-rao-a added this to the June 2017 milestone Jun 29, 2017
ramya-rao-a added a commit that referenced this issue Jun 29, 2017
@ramya-rao-a
Copy link
Contributor

Thank for reporting @smlombardi !

I have seen you file other issues around Emmet Actions as well.

Can you take a look at other Emmet Actions and see how that works out for you?
For the new emmet model, we had to re-implement all of the Emmet actions except the below

  • Emmet: Reflect CSS Value
  • Emmet: Update Image Size

@ramya-rao-a
Copy link
Contributor

Fixed with 4ea63e5

@isidorn isidorn added the verified Verification succeeded label Jun 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants