-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additions to "emmet.includeLanguages" require reload #29968
Comments
The fix is to listen to the config change event and register new completion providers for the newly added languages in |
I take a look, I saw this in other extensions and it isn't that hard. |
Yes, not hard at all. Feel free to submit a PR |
I can't get it to work, reload or not. |
It works for me, for example when I add XML files manually to emmet. And those are the same methods, so when it works for the standard languages, it should work for custom ones too. |
I still didn't see Emmet proposals after adding this setting. Should those proposals show up in the suggestion window? @ramya-rao-a |
The reason why @roblourens and @rebornix were not able to get any suggestions was because they hadn't set I had initially introduced But in the last month there have been many improvements and now non css emmet suggestions only show up if the word is one of the commonly used html tags or is a valid abbreviation with operators like This "always" vs "markupAndStylesheetOnly" option may not be required any more |
On spending more time thinking on #29968 (comment), I feel its not wise to remove the "markupAndStylesheetOnly" option altogether. There can still be cases where emmet suggestions showing up in wrong places annoying users. Instead, as a middle ground, we can change the default for this setting to This way, the moment a mapping has been added to This is done with dd7adcc |
Steps to Reproduce:
emmet.includeLanguages
"emmet.includeLanguages": { "javascript": "javascriptreact" }
The text was updated successfully, but these errors were encountered: