Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all Emmet commands from core to extension and localize #29969

Closed
ramya-rao-a opened this issue Jun 30, 2017 · 1 comment
Closed

Move all Emmet commands from core to extension and localize #29969

ramya-rao-a opened this issue Jun 30, 2017 · 1 comment
Assignees
Labels
debt Code quality issues emmet Emmet related issues
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

Currently all the emmet commands get routed from the core to the emmet extension.
This was so that when users use emmet.useNewEmmet to false, we fall back on the old emmet implementation.

In July, all emmet commands will be using the new model and so will be used out of the extension directly

@vscodebot vscodebot bot added the emmet Emmet related issues label Jun 30, 2017
@ramya-rao-a ramya-rao-a added the debt Code quality issues label Jun 30, 2017
@ramya-rao-a ramya-rao-a added this to the July 2017 milestone Jun 30, 2017
@ramya-rao-a
Copy link
Contributor Author

All emmet commands other than Emmet: Expand Abbreviation and Emmet: Wrap with Abbreviation have been moved to the extension.

The remaining 2 commands are blocked on an upstream fix without which we cannot make the new experience the default. #27784

Will use #29244 to track the moving of the remaining 2 commands

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues emmet Emmet related issues
Projects
None yet
Development

No branches or pull requests

1 participant