Improve wording on "Save Workspace dialog"

[weinand]

Testing #30722:

• open an untitled multi-root workspace in VS Code
• try to open a folder in the same window

Observe: you get this dialog:

I don't think that "opened in this window" is really necessary, so I would drop it from the message.

I recommend to use the term "untitled workspace" to make clear what the real reason is. For named workspaces you will not be prompted so save.

"Your workspace will be deleted" sounds very aggressive. I suggest to use something like
"You lose your workspace if you don't save it" (but when reading this, it sounds so obvious that I think we should drop the second sentence completely).

In general we should keep the text on these dialogs as short as possible because users don't want to spend lots of time reading these explanations.

[bpasero]

@weinand how about this?

I like the "details" of a dialog because it gives it some balance over this:

[weinand]

In general, you don't have to save the workspace under a name in order to open it again. It opens automatically if it's untitled.
But in the special case of the "Open Folder", you need to save it under a name otherwise it's lost.
So "You lose your workspace if you don't save it" would be more precise.

But I'm fine with your first proposal as well.

[bpasero]

@weinand yeah it is true that you can open an untitled workspace without saving however in this case it is really gone if you do not save. I like both proposals, let's see how our users react to this 👍

[chrisdias]

I'm not sure we need to use the word "untitled" in this dialog. Is the thing that I want to save "untitled workspace" or is it a workspace with no title? Is an "untitled workspace" a thing that I need to know about?

As a comparison, consider this dialog:

(as an aside, I'm not sure the sub-message that says your changes will be lost if you don't save them is necessary, it seems pretty obvious :))

In this case I'm being asked to save a thing "Untitled-1".

A more consistent message would be:

"Do you want to save the changes you made to workspace "Untitled"?"

But, since there can ever only be one unsaved and therefore untitled workspace, you can even eliminate it and just prompt:

"Do you want to save your workspace?".

[bpasero]

@chrisdias I think @weinand reasoning was to emphasize that you are not being asked to save any other workspace that is saved (hence the "untitled" in the name).

I am fine removing that again, but let @weinand speak up.

One thing we have to keep in mind is that the dialog should not look too similar to the one you get when saving files. So the wording should not be too similar imho.

[weinand]

If a user has turned on "Auto Save" she will probably be surprised if she sees a "Do you want to save your workspace?". By mentioning "untitled" I tried to make clear that the missing name is the problem here, and not the save (because that happens automatically).
If you do not agree that this might be an issue, then please go with the wording without the "untitled".

[bpasero]

Maybe the term "Untitled Workspace" is a bit misleading here because it is overloaded with "Untitled" file that we have when you create a new file? I am happy to change the wording if someone has a better idea.

Neither the auto save configuration nor the hot exit configuration has any impact on how we prompt for untitled workspaces btw.

[weinand]

"Do you want to save your workspace configuration as a file?"

(I'm using the term "configuration" to make clear that this is not the workspace content, so nothing really bad happens if you don't save)

[bpasero]

Looks good to me: