Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should shrinkwrap files be ignored? #31307

Closed
praveenpuglia opened this issue Jul 24, 2017 · 2 comments
Closed

Should shrinkwrap files be ignored? #31307

praveenpuglia opened this issue Jul 24, 2017 · 2 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) engineering VS Code - Build / issue tracking / etc.

Comments

@praveenpuglia
Copy link
Contributor

pulled in latest from master, ran ./scripts/npm install and I see a bunch of shrinkwrap files that got modified.

I am not sure what to do with them when sending a PR. Should those be ignored?

        modified:   ../../configuration-editing/npm-shrinkwrap.json
	modified:   ../npm-shrinkwrap.json
	modified:   npm-shrinkwrap.json
	modified:   package.json
	modified:   ../../emmet/npm-shrinkwrap.json
	modified:   ../../emmet/package.json
	modified:   ../../extension-editing/npm-shrinkwrap.json
	modified:   ../../git/npm-shrinkwrap.json
	modified:   ../../git/package.json
	modified:   ../../grunt/npm-shrinkwrap.json
	modified:   ../../grunt/package.json
	modified:   ../../gulp/npm-shrinkwrap.json
	modified:   ../../gulp/package.json
	modified:   ../../html/npm-shrinkwrap.json
	modified:   ../../html/package.json
	modified:   ../../html/server/npm-shrinkwrap.json
	modified:   ../../jake/npm-shrinkwrap.json
	modified:   ../../jake/package.json
	modified:   ../../javascript/npm-shrinkwrap.json
	modified:   ../../javascript/package.json
	modified:   ../../json/npm-shrinkwrap.json
	modified:   ../../json/package.json
	modified:   ../../json/server/npm-shrinkwrap.json
	modified:   ../../markdown/npm-shrinkwrap.json
	modified:   ../../merge-conflict/npm-shrinkwrap.json
	modified:   ../../merge-conflict/package.json
	modified:   ../../npm-shrinkwrap.json
	modified:   ../../npm/npm-shrinkwrap.json
	modified:   ../../npm/package.json
	modified:   ../../php/npm-shrinkwrap.json
	modified:   ../../php/package.json
	modified:   ../../typescript/npm-shrinkwrap.json
	modified:   ../../typescript/package.json
	modified:   ../../vscode-api-tests/package.json
	modified:   ../../vscode-colorize-tests/package.json
	modified:   ../../../npm-shrinkwrap.json
	modified:   ../../../package.json
@vscodebot vscodebot bot added the json JSON support issues label Jul 24, 2017
@praveenpuglia
Copy link
Contributor Author

I didn't realize I was on node 8+ and NPM 5+ and it looks like vscode doesn't support them yet? Please confirm this and close.

@mjbvz mjbvz added *duplicate Issue identified as a duplicate of another issue(s) engineering VS Code - Build / issue tracking / etc. labels Jul 24, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Jul 24, 2017

Yes, we do not support npm 5 currently and are tracking support with #30134

Closing as a duplicate of #30134

@mjbvz mjbvz marked this as a duplicate of #30134 Jul 24, 2017
@mjbvz mjbvz closed this as completed Jul 24, 2017
@mjbvz mjbvz removed the json JSON support issues label Jul 24, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*duplicate Issue identified as a duplicate of another issue(s) engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@praveenpuglia @mjbvz