Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show the currently active launch config #31745

Closed
egamma opened this issue Jul 31, 2017 · 2 comments
Closed

Always show the currently active launch config #31745

egamma opened this issue Jul 31, 2017 · 2 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan
Milestone

Comments

@egamma
Copy link
Member

egamma commented Jul 31, 2017

In the multi root setup with a client and a server I frequently shift between launching the client and sometimes attaching to the server. After I've attached to the server I often forgot that I did so and then when I launch the client again, then the launching appears to fail, since the server attach launch config is the current one and the Debug viewlet is not visible. For this reason it would be helpful to the user to always see the current launch config in the UI or even better so that the user can always switch the active launch config.

One option is something similar to the git branch switcher in the status bar.

@egamma egamma added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 31, 2017
@isidorn isidorn added feature-request Request for new features or functionality under-discussion Issue is under discussion for relevance, priority, approach labels Jul 31, 2017
@isidorn isidorn added this to the August 2017 milestone Jul 31, 2017
@isidorn
Copy link
Contributor

isidorn commented Jul 31, 2017

Assigning to august for discussion.

We can show it in the status bar, however do we do this for all cases or only for the multi root experience? Even though the need for it is higher in the multi root case it is also helpful in the single root so being consistent and showing it always is my preffered solution.

Also do we show this only while a debug session is active or always? If always it may prove to be too much noise.
If the user does not have a launch.json configured then I would definetelly not show anything.

I think showing it while a debug session is active for any workspace is the safest path.

@weinand
Copy link
Contributor

weinand commented Aug 22, 2017

Let's try to show the selected config in the status bar.
I suggest to show it even if no debug session is running because pressing F5 outside of the debug view is often a guessing game (and the status bar item could solve that).

I do not think that it is worth the effort to hide the item when the debug view is shown (and the selected config is already visible in the drop down).

Clicking on the status bar item should open QuickPick with a list of all launch configs.

@weinand weinand removed their assignment Aug 22, 2017
@isidorn isidorn removed the under-discussion Issue is under discussion for relevance, priority, approach label Aug 28, 2017
@isidorn isidorn modified the milestones: September 2017, August 2017 Aug 29, 2017
@isidorn isidorn modified the milestones: September 2017, October 2017 Sep 25, 2017
@isidorn isidorn closed this as completed in 8cf2863 Oct 6, 2017
@isidorn isidorn mentioned this issue Oct 9, 2017
2 tasks
sandy081 pushed a commit that referenced this issue Oct 16, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

3 participants