Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure task runner should only open output if autodetection fails or provides output. #3304

Closed
isidorn opened this issue Feb 23, 2016 · 7 comments
Closed

Configure task runner should only open output if autodetection fails or provides output. #3304

isidorn opened this issue Feb 23, 2016 · 7 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone
March 2016

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 23, 2016

#3159

Configure task runner command reveals task output, it should not since there is no new output.
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Feb 23, 2016
@joaomoreno
Copy link
Member

👍

@joaomoreno joaomoreno added this to the Feb 2016 milestone Feb 23, 2016
@seanmcbreen
Copy link

+1

@joaomoreno joaomoreno assigned isidorn and unassigned dbaeumer Feb 24, 2016
@isidorn
Copy link
Contributor Author

isidorn commented Feb 25, 2016

ping @dbaeumer so you are aware of the change

@isidorn isidorn assigned joaomoreno and unassigned isidorn Feb 25, 2016
@joaomoreno joaomoreno added the verified Verification succeeded label Feb 26, 2016
@dbaeumer
Copy link
Member

Reopening and reverting the commit. The problem here is that if the autodetection fails output is shown in the console. Now the user is blind.

@dbaeumer dbaeumer reopened this Feb 29, 2016
dbaeumer added a commit that referenced this issue Feb 29, 2016
@dbaeumer
Reverting #3304
a297179
@dbaeumer dbaeumer removed the verified Verification succeeded label Feb 29, 2016
@dbaeumer dbaeumer assigned dbaeumer and unassigned joaomoreno Feb 29, 2016
@dbaeumer dbaeumer changed the title Configure task runner should not open output Configure task runner should only open output if autodetection fails or provides output. Feb 29, 2016
@dbaeumer dbaeumer modified the milestones: March 2016, Feb 2016 Feb 29, 2016
dbaeumer added a commit that referenced this issue Mar 17, 2016
@dbaeumer
Fixes #4177 ('Auto detecting the task system failed' can be more user…
a3209b5 
… friendly) and #3304 (Configure task runner should only open output if autodetection fails or provides output.)
@dbaeumer
Copy link
Member

Fixed.

@dbaeumer
Copy link
Member

@isidorn let me know if you are more happy with the new implementation.

@dbaeumer dbaeumer assigned isidorn and unassigned dbaeumer Mar 21, 2016
@isidorn
Copy link
Contributor Author

isidorn commented Mar 23, 2016

@dbaeumer looks good to me

@isidorn isidorn added the verified Verification succeeded label Mar 23, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Milestone
March 2016
Development

No branches or pull requests
4 participants
@joaomoreno @seanmcbreen @isidorn @dbaeumer