Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extension-editing extension is slow to startup #33141

Closed
alexdima opened this issue Aug 25, 2017 · 5 comments
Closed

extension-editing extension is slow to startup #33141

alexdima opened this issue Aug 25, 2017 · 5 comments
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug perf verified Verification succeeded
Milestone
September 2017

Comments

@alexdima
Copy link
Member

  • open e.g. a folder and leave a .ts file opened
  • run ./scripts/code.sh --performance
  • F1 > Developer: Startup Performance

screen shot 2017-08-25 at 11 51 10
@jrieken jrieken added the perf label Aug 25, 2017
@jrieken
Copy link
Member

jrieken commented Aug 25, 2017

Cool. It does use jsonc-parser and vscode-nls unsure if its them...

@jrieken jrieken assigned isidorn and unassigned isidorn Aug 25, 2017
jrieken added a commit that referenced this issue Aug 28, 2017
@jrieken
use async module loading for typescript, #33141
6302112
@jrieken
Copy link
Member

jrieken commented Aug 28, 2017 •
edited

It takes ~450ms to load TypeScript, the rest is spent for extensionLinter.ts which loads a markdown and xml parser. I have made the typescript-module loading async, @chrmarti for the rest

@jrieken jrieken assigned chrmarti and unassigned jrieken Aug 28, 2017
@chrmarti chrmarti added this to the September 2017 milestone Aug 29, 2017
@chrmarti
Copy link
Contributor

chrmarti commented Sep 7, 2017

@jrieken Should I just defer the module loading until I actually need the parsers?

@jrieken
Copy link
Member

jrieken commented Sep 8, 2017

Yeah, that's what I did. With the new TS supports it's easy to do

@chrmarti chrmarti added the bug Issue identified by VS Code Team member as probable bug label Sep 27, 2017
@alexdima
Copy link
Member Author

Nice !

@alexdima alexdima added the verified Verification succeeded label Sep 28, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug perf verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
4 participants
@jrieken @isidorn @alexdima @chrmarti