Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension Host Restart doesn't close messages from previously crashed extension host #33368

Closed
egamma opened this issue Aug 29, 2017 · 1 comment
Closed

Extension Host Restart doesn't close messages from previously crashed extension host #33368

egamma opened this issue Aug 29, 2017 · 1 comment
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2017

Comments

@egamma
Copy link
Member

egamma commented Aug 29, 2017 •
edited

Testing #33300

  • I had an extension host crash after an error

image

  • I executed Restart Extension Host.

I ended up in this state

image

Suggest to close the messages, since with the message box visible it is not clear to me when the extension host restart is done.
@alexdima
Copy link
Member

... I could call IMessageService.hideAll() ... although there is no proof that the errors are correlated. But I see lots of calls to that from other places that have no clue what they're dismissing...

@alexdima alexdima added this to the August 2017 milestone Aug 29, 2017
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Aug 31, 2017
jrieken pushed a commit that referenced this issue Sep 1, 2017
@alexdima @jrieken
Fixes #33368
fc67682
@weinand weinand added the verified Verification succeeded label Sep 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
3 participants
@egamma @weinand @alexdima