Inline decorations can conflict with one another

[eamodio]

• VSCode Version: Code - Insiders 1.16.0-insider (1452d0a, 2017-09-04T20:15:38.808Z)
• OS Version: Windows_NT x64 10.0.16281

---

I have both GitLens and Import Cost extensions installed and the decorators added to the end of the line by both seem to conflict as can be seen below.

I would have either expected the GitLens decoration to no appear at all (less than ideal imo) or that the GitLens decoration (since it was being added last) would win (and once it was removed it would revert to the previous one). But currently it looks like some properties between the 2 decorators get merged which looks far less than ideal 😄

Originally reported here: gitkraken/vscode-gitlens#131

Reproduces without extensions: No

[rebornix]

@eamodio we applied CSS for decorations to the elements so if there are two decorators on the same character, we don't decide which one should be shown, which one should not.

But for this particular case, there is a workaround to make it look better

Both the first rule and third rule are from GitLens while Import Cost put them in the same rule. I suppose GitLens tries to add a new decoration for current selected line, that's why it has the top priority. A workaround is merging them

.currentline {
  color: rgba()
  content: ""
}

.others {
  content: ""
}

[eamodio]

I debugged this a bit from the GitLens side and I see that I am setting a few decorations (1 for the trailing content, 1 for the commit details hover, 1 for the commit changes hover). It seems like the trailing content decoration is the issue here. This is what I am setting:

{
    range,
    renderOptions: {
        after: {
            contentText: "context goes here"
        },
        dark: {
            after: {
                backgroundColor: undefined,
                color: "rgba(153, 153, 153, 0.35)"
            }
        }.
        light: {
            after: {
                backgroundColor: undefined,
                color: "rgba(153, 153, 153, 0.35)"
            }
        }
    }
}

So I think the splitting of the css is because of the use of theme blocks.

[roblourens]

@rebornix I'm not sure what the resolution is or where this needs to go. Can I assign back to you?

[rebornix]

Mark it under-discussion first. Decorations provided by extensions don't have priorities and we merge them and let browser do the merging/overriding/etc.

[alexdima]

It looks like now the two end-of-line decorations now get appended one after the other, which I consider more reasonable than the previous merging: