Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hang then crash by typing \\\\\\\\\\\\\\\\ in integrated terminal #34039

Closed
jamesjryan opened this issue Sep 8, 2017 · 2 comments
Closed

Hang then crash by typing \\\\\\\\\\\\\\\\ in integrated terminal #34039

jamesjryan opened this issue Sep 8, 2017 · 2 comments
Assignees
@Tyriar
Labels
candidate Issue identified as probable candidate for fixing in the next release freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August Recovery 2017

Comments

@jamesjryan
Copy link

  • VSCode Version: Code 1.16.0 (787b31c, 2017-09-06T16:12:42.401Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions:
Extension Author (truncated) Version
beautify Hoo 1.1.1
vscode-docker Pet 0.0.16
code-settings-sync Sha 2.8.3
vscode-eslint dba 1.3.0
tslint eg2 1.0.1
cpptools ms- 0.12.3
autoimport ste 1.2.2
react-beautify tai 0.3.0
vim vsc 0.10.0
ReactSnippets xab 1.4.0

Steps to Reproduce:

  1. Open integrated terminal
  2. Type \\\\\\\\\\\\\\\\\\\\\\\\\\

All of vscode will immediately hang. You will not be able to use any of the UI.
After a while it will show a macOS dialog "The window is no longer responding" with options to Close/Keep Waiting/Reopen.

This will happen regardless of whether the current working directly is a git repository or not.

Using a mid 2015 MacBook Pro.

Using zsh terminal with oh-my-zsh framework. It is not possible to reproduce this issue in a regular terminal, either macOS Terminal.app or iTerm.

Reproduces without extensions: Yes/No
@vscodebot vscodebot bot added the new release label Sep 8, 2017
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Sep 8, 2017
@Tyriar Tyriar added this to the August Recovery 2017 milestone Sep 8, 2017
@Tyriar Tyriar added candidate Issue identified as probable candidate for fixing in the next release freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues labels Sep 8, 2017
Tyriar added a commit that referenced this issue Sep 11, 2017
@Tyriar
Fix regex-related crash in terminal code
7761d2c 
Fixes #34039
@Tyriar Tyriar closed this as completed in b57688a Sep 11, 2017
@Tyriar
Copy link
Member

Tyriar commented Sep 11, 2017

Pushed to master and release/1.16.

@jamesjryan
Copy link
Author

Thanks for dealing with this so promptly @Tyriar 👍

Tyriar added a commit that referenced this issue Sep 12, 2017
@Tyriar
Fix tests and link line/column matching
bc4a020 
Part of #34039
Related #33955
@Tyriar Tyriar mentioned this issue Sep 12, 2017
Closed
@weinand weinand added verification-needed Verification of issue is requested verified Verification succeeded labels Sep 14, 2017
This was referenced Sep 14, 2017
Closed
Closed
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
candidate Issue identified as probable candidate for fixing in the next release freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August Recovery 2017
Development

No branches or pull requests
3 participants
@weinand @Tyriar @jamesjryan