Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting 'editor.action.triggerSuggest' as post completion command does show proposals #34565

Closed
aeschli opened this issue Sep 18, 2017 · 2 comments
Closed

Setting 'editor.action.triggerSuggest' as post completion command does show proposals #34565

aeschli opened this issue Sep 18, 2017 · 2 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone
October 2017

Comments

@aeschli
Copy link
Contributor

aeschli commented Sep 18, 2017

Inspired by #31948:

The idea is that on a completion of a css property, code assist is activated again, to show the proposals for the property values.

  • add 'editor.action.triggerSuggest' as post completion command
  • invoke the completion proposal
  • observe no completion window is opened

The triggerSuggest command is called, proposals are requested from the providers, but the operation is canceled before any suggestions are shown.
(cancel seems to come from SuggestController._onDidSelectItem)
@vscodebot vscodebot bot added the api label Sep 18, 2017
@aeschli aeschli changed the title Setting 'editor.action.triggerSuggest' as post completion command does not work Setting 'editor.action.triggerSuggest' as post completion command does show proposals Sep 18, 2017
@aeschli aeschli added the suggest IntelliSense, Auto Complete label Sep 18, 2017
@aeschli aeschli mentioned this issue Sep 18, 2017
Closed
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug and removed api labels Sep 18, 2017
@jrieken jrieken added this to the October 2017 milestone Sep 18, 2017
@jrieken
Copy link
Member

jrieken commented Sep 18, 2017

Yeah, it seems that after accepting/inserting a completion we always finish/cancel suggestion not being aware that in the meantime a new session has started...

@jrieken jrieken mentioned this issue Sep 22, 2017
Closed
@jrieken jrieken closed this as completed in eab541f Oct 4, 2017
sandy081 pushed a commit that referenced this issue Oct 16, 2017
@jrieken @sandy081
fix #34565
c231820
@aeschli aeschli added the verified Verification succeeded label Nov 3, 2017
@aeschli
Copy link
Contributor Author

aeschli commented Nov 3, 2017

Verified by a code example

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
2 participants
@jrieken @aeschli