Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab in Search field in Replace in Files should focus Replace field #34676

Closed
willfaught opened this issue Sep 20, 2017 · 3 comments
Closed

Tab in Search field in Replace in Files should focus Replace field #34676

willfaught opened this issue Sep 20, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone

Comments

@willfaught
Copy link

willfaught commented Sep 20, 2017

And shift-tab in the Replace field should then move the focus back to the Search field. This is the tab focus behavior in the Edit > Replace fields. This would enable rapidly doing many different replacements by tabbing and shift-tabbing between the Search and Replace fields.

  • VSCode Version: Code 1.16.1 (27492b6, 2017-09-14T16:24:39.530Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions:
Extension Author (truncated) Version
vscode-docker Pet 0.0.17
php-formatter Sop 0.2.4
sort-lines Tyr 1.3.0
githistory don 0.2.3
javadebugger don 0.1.3
python don 0.7.0
phpunit ema 2.1.1
git-project-manager fel 1.4.0
php-debug fel 1.11.1
php-intellisense fel 1.5.1
code-runner for 0.7.1
vscode-javac geo 0.0.46
phpcs ika 0.7.0
Go luk 0.6.65
prettify-json moh 0.0.3
mssql ms- 1.1.0
cpptools ms- 0.12.4
Ruby reb 0.15.0
rewrap stk 1.5.0
gitblame wad 2.2.0
vscode-proto3 zxh 0.1.2

Steps to Reproduce:

  1. Select Edit > Replace in Files.
  2. Focus the Search field.
  3. Press tab.
  4. The Match Case toggle is focused instead of the Replace field.

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the search Search widget and operation issues label Sep 20, 2017
@willfaught willfaught changed the title Pressing tab in Replace in Files with the Search field focused should focus the Search field Tab in the Search field in Replace in Files should focus the Search field Sep 20, 2017
@willfaught willfaught changed the title Tab in the Search field in Replace in Files should focus the Search field Tab in Search field in Replace in Files should focus Replace field Sep 20, 2017
@roblourens
Copy link
Member

You can also use the arrow keys to switch between the fields. We also have #12645 to revisit this. I wonder whether the editor find widget has changed this because I thought they were consistent before. Maybe we should at least change the tab order in the search viewlet to match the find widget.

@roblourens roblourens added the feature-request Request for new features or functionality label Sep 20, 2017
@roblourens roblourens added this to the September 2017 milestone Sep 20, 2017
@roblourens
Copy link
Member

That turns out to be easier said than done

@roblourens roblourens modified the milestones: November 2017, December 2017 Dec 4, 2017
@roblourens roblourens removed this from the December 2017/January 2018 milestone Jan 6, 2018
@roblourens roblourens added this to the June 2018 milestone Jun 12, 2018
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Jun 12, 2018
@roblourens
Copy link
Member

This was fixed by @sandy081's changes in Insiders for 1.25

@chrmarti chrmarti added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants