Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: link origin of messages in debug console #34756

Closed
3 tasks done
isidorn opened this issue Sep 21, 2017 · 0 comments
Closed
3 tasks done

Test: link origin of messages in debug console #34756

isidorn opened this issue Sep 21, 2017 · 0 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 21, 2017

Refs: #24490

Complexity: 3

We now support showing the origin of messages in debug console. Note that this is currently only supported by the node2 debug adapter. Have some nedo repository, for example our smoketest and if you have node below version 8 add "inspector": "protocol" to the launch configuration.

Verify:

  • all output logged should appear in the debug console with a proper origin.
  • clicking on the origin takes you to the appropriate file / line number / column

When using console.log, console.warn or console.error from an extension, the log information is serialised from the extension host to the renderer and then played back in the renderers DevTools console as well as debug console. This means that the origin of the console use from the extension is lost. We now preserve the origin and allow access to it.

Use console.log, console.warn or console.error from your extension with strings, objects, primitives etc. Have some extension repository and verify:

  • you can expand the message in the extension host dev tools to see the full stack of where the message was sent
  • you see the location of the message in the right hand side of the debug console and can click on it
  • the data that you log is not shown up in a bad way or is lost
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item labels Sep 21, 2017
@isidorn isidorn added this to the September 2017 milestone Sep 21, 2017
@jrieken jrieken removed this from the September 2017 milestone Sep 26, 2017
@chrmarti chrmarti added this to the September 2017 milestone Sep 26, 2017
@chrmarti chrmarti removed their assignment Sep 26, 2017
@octref octref removed their assignment Sep 26, 2017
@dbaeumer dbaeumer removed their assignment Sep 27, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

5 participants