Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console.logs from command handler not linked to origin #35140

Closed
chrmarti opened this issue Sep 26, 2017 · 7 comments
Closed

Console.logs from command handler not linked to origin #35140

chrmarti opened this issue Sep 26, 2017 · 7 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
September 2017

Comments

@chrmarti
Copy link
Contributor

  • VSCode Version: Code - Insiders 1.17.0-insider (a5210bc, 2017-09-26T05:11:30.780Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions: Many

Testing #34756

Steps to Reproduce:

  1. Logging from activate() works as expected
  2. Logging from a command handler shows extensionHostProcess.js as the origin

image
@chrmarti chrmarti added the debug Debug viewlet, configurations, breakpoints, adapter issues label Sep 26, 2017
@vscodebot vscodebot bot added the insiders label Sep 26, 2017
@bpasero bpasero self-assigned this Sep 26, 2017
@bpasero bpasero added this to the September 2017 milestone Sep 26, 2017
@octref
Copy link
Contributor

octref commented Sep 26, 2017

Same for macOS.

@bpasero
Copy link
Member

bpasero commented Sep 27, 2017

@chrmarti @octref I cannot reproduce, are you sure you both test on latest? Can you try if it reproduces in todays build and then upload your sources somewhere?

@bpasero bpasero added the info-needed Issue requires more information from poster label Sep 27, 2017
@octref
Copy link
Contributor

octref commented Sep 27, 2017 •
edited

@bpasero

a5210bc is the one I was using.

image

The highlighted console.log is the only change I made after yo code using JS template.

@octref
Copy link
Contributor

octref commented Sep 27, 2017

Same for 67a8479 released 20 min ago.

@bpasero bpasero removed the info-needed Issue requires more information from poster label Sep 27, 2017
@bpasero
Copy link
Member

bpasero commented Sep 27, 2017

Ok only happens in JS extension, the issue is this top frame that I fail to parse:

image

@bpasero bpasero mentioned this issue Sep 27, 2017
Closed
@octref
Copy link
Contributor

octref commented Sep 29, 2017

Actually still happens on Windows for this version:

  • VSCode Version: Code - Insiders 1.17.0-insider (f7dc950, 2017-09-28T17:50:54.394Z)

image

@octref octref reopened this Sep 29, 2017
@bpasero
Copy link
Member

bpasero commented Sep 29, 2017

@octref thanks for finding this!

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed labels Sep 29, 2017
@chrmarti chrmarti added verified Verification succeeded and removed verification-found Issue verification failed labels Sep 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
4 participants
@bpasero @isidorn @octref @chrmarti