Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git.publish ask for remote if only one is setup #35373

Closed
KnisterPeter opened this issue Sep 29, 2017 · 2 comments · Fixed by #35485
Closed

git.publish ask for remote if only one is setup #35373

KnisterPeter opened this issue Sep 29, 2017 · 2 comments · Fixed by #35485
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities
Milestone
Backlog

Comments

@KnisterPeter
Copy link
Contributor

  • VSCode Version: 1.16.1
  • OS Version: Linux

Steps to Reproduce:

  1. Create project with git setup and just one remote.
  2. Execute git.publish
  3. QuickPick is shown with the one configured remote

I would suggest to skip the quickpick if there is just one remote. It would simplify the UX of git.pubish.
@vscodebot vscodebot bot added the git GIT issues label Sep 29, 2017
@joaomoreno joaomoreno added good first issue Issues identified as good for first-time contributors bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities labels Oct 2, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Oct 2, 2017
@joaomoreno
Copy link
Member

Would you like to attempt a PR?

@KnisterPeter
Copy link
Contributor Author

Sure ☺️

KnisterPeter added a commit to KnisterPeter/vscode that referenced this issue Oct 2, 2017
@KnisterPeter
fix: use single remote automatically
855a55d 
If there is only one remote configured just use it instead of aksing the user which remote to use.

Closes microsoft#35373
This was referenced Oct 2, 2017
Closed
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix: use single remote automatically KnisterPeter/vscode
2 participants
@joaomoreno @KnisterPeter