Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing terminal font family does not correctly re-evaluate rows/cols of backgrounded terminals #35763

Closed
Tyriar opened this issue Oct 6, 2017 · 0 comments · Fixed by #36288
Closed

Changing terminal font family does not correctly re-evaluate rows/cols of backgrounded terminals #35763

Tyriar opened this issue Oct 6, 2017 · 0 comments · Fixed by #36288
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone
October 2017

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 6, 2017 •
edited

Repro steps:

  1. Open terminal
  2. Open another terminal
  3. Change the terminal font via terminal.integrated.fontFamily, notice the terminal's font changes
  4. Switch to the other terminal, it's still using the old font
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Oct 6, 2017
@Tyriar Tyriar added this to the October 2017 milestone Oct 6, 2017
@Tyriar Tyriar self-assigned this Oct 6, 2017
@Tyriar Tyriar changed the title Changing terminal font family does not correctly re-evaluate rows/cols Changing terminal font family does not correctly re-evaluate rows/cols of backgrounded terminals Oct 13, 2017
Tyriar added a commit that referenced this issue Oct 14, 2017
@Tyriar
Only update terminal display settings when visible
3049d48 
Fixes #35763
@Tyriar Tyriar mentioned this issue Oct 14, 2017
Merged
sandy081 pushed a commit that referenced this issue Oct 16, 2017
@Tyriar @sandy081
Only update terminal display settings when visible
6d51ba5 
Fixes #35763
@mjbvz mjbvz added the verified Verification succeeded label Nov 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
October 2017
Development

Successfully merging a pull request may close this issue.

Only update terminal display settings when visible microsoft/vscode
2 participants
@Tyriar @mjbvz